From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50FC5C4332F for ; Fri, 10 Nov 2023 20:44:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A9F89210; Fri, 10 Nov 2023 21:43:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A9F89210 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699649057; bh=s+usg5G1PxXFqdDFnY9JX95KjKsHO/ZrjGdrtzctvVw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=nxNaIxsZvPcDiZ4ITCCfGL+DIibUvMp76jtAz3lnckNA8jcjgif2z9B0lztCAK5dj KzSskm/KCO6oYkTweTOXNcVyv3jkU097Y8pm2asz4LBsZhIEjFa1R7cQ4CUhhAmt8i Whg2ThbC0i9MPUGOY7jKnzWoj7eHsAKaIPCeGYao= Received: by alsa1.perex.cz (Postfix, from userid 50401) id ADBCCF80166; Fri, 10 Nov 2023 21:43:07 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 7386DF800ED; Fri, 10 Nov 2023 21:43:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EB5B9F80166; Fri, 10 Nov 2023 21:43:01 +0100 (CET) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5D7C6F80152 for ; Fri, 10 Nov 2023 21:42:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5D7C6F80152 Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-6ce2ee17cb5so1326571a34.2 for ; Fri, 10 Nov 2023 12:42:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648971; x=1700253771; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EYRGPcRyh2b3fkqQmyXc07beY1rNkEkbKXxns94N0UA=; b=txGPiZWkg7YeA+h81U9kUH8yy/D5cXc9xuPkD0cUksI43d6ANRVFWM6slQb+IviCiW mEsjlpSgt8eXuA9fgbKU8UJM6SV26kRA5rkj7eAtEKPv6Z9Hd0j8skiIpTDFZzmems2a hX+eCYDAptCkUwqTxS5fxiE2EbiBv6wNJS7DjAueQMjt6LaOC46qRm4Iu4nxqPqnl1Ds G2dF6MTaHOqbSY7nlP5o9b+eY/D3TdWBD1xWkR1kC6ZTCPZ27KUjbksvwCRpcOmKCiqG Xrfm7DWmxShooh/tka0n7Y2jUHhgVYscTH7DUvyRDXx0PVOooayWav8eD8Zg3qsBAiRn dHpA== X-Gm-Message-State: AOJu0YyqAslpdS6YN8AoSCIj+jMwVE/k8QDJ+fQcxQse2sDqcSaHSksL +7re2fY33sHp9KFDAiEmbw== X-Google-Smtp-Source: AGHT+IEbpkkUwMS8m0HRQeTKdMYwXj4e9rjshafhVsgnG4tRletjT6wKTUFDB5opO1qLTOQnh19aYQ== X-Received: by 2002:a05:6808:23cb:b0:3b6:d617:a6f7 with SMTP id bq11-20020a05680823cb00b003b6d617a6f7mr539897oib.3.1699648970928; Fri, 10 Nov 2023 12:42:50 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id x26-20020a54401a000000b003b2e3e0284fsm42223oie.53.2023.11.10.12.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:42:50 -0800 (PST) Received: (nullmailer pid 397808 invoked by uid 1000); Fri, 10 Nov 2023 20:42:48 -0000 Date: Fri, 10 Nov 2023 14:42:48 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, Sylwester Nawrocki , linux-mmc@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Greg Kroah-Hartman , Jiri Slaby , Andi Shyti , Alessandro Zummo , Conor Dooley , Mark Brown , Thomas Zimmermann , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sam Protsenko , Alim Akhtar , Liam Girdwood , linux-pwm@vger.kernel.org, Daniel Vetter , David Airlie , Thierry Reding , Rob Herring , Lars-Peter Clausen , Jonathan Cameron , linux-sound@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Maarten Lankhorst , Linus Walleij , linux-samsung-soc@vger.kernel.org, Tomasz Figa , alsa-devel@alsa-project.org, Alexandre Belloni , linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, Krzysztof Kozlowski , Ulf Hansson , Lee Jones , Jaehoon Chung , dri-devel@lists.freedesktop.org, Maxime Ripard , linux-rtc@vger.kernel.org Subject: Re: [PATCH 10/17] dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC Message-ID: <169964896802.397769.16770997428730838541.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> Message-ID-Hash: TCFAJC2A6PU3Y3XYZIVMHP44IYCQMADO X-Message-ID-Hash: TCFAJC2A6PU3Y3XYZIVMHP44IYCQMADO X-MailFrom: robherring2@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 08 Nov 2023 11:43:36 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > Acked-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E835BC4332F for ; Fri, 10 Nov 2023 20:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ymIN1djsvEF5OaOZIfweKIDD6NUgr5MCEJgqR20fU8Y=; b=nnP7N8+0PuOpBS IR84W6DXWjatnVtPqfu98FDfNBUFaeQZgx+hl7M5PWecOb7Rn58vHbZFyIwV3IaW0g6rsxghAfKZ9 FO6NR4Umf2bsjrGdW2NhAiMtyrWENK2n62zMxaYkum75oS9dwKK8wGJdk5+KQlveswIJuR02ryPtH xqi6tvElRYRpEmRSNe++gbUQBzmOrD0Bp/Xc3jpi4Hm88Exmz1Z5oPwBGmeBMJO1df2SwJJ4+tNrO RBXBnNg0EXGrk6gtQCARiFAheRffFv/f7wNrt5ggI+daarpUSd2ZKOKmhrB0Kpk/185TG+oEfwXFo rOr3pae5SqvTR1p6JlZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1YL8-009PeQ-2U; Fri, 10 Nov 2023 20:42:54 +0000 Received: from mail-ot1-f48.google.com ([209.85.210.48]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1YL5-009PdX-27 for linux-arm-kernel@lists.infradead.org; Fri, 10 Nov 2023 20:42:52 +0000 Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-6ce2988d62eso1332219a34.1 for ; Fri, 10 Nov 2023 12:42:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648971; x=1700253771; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EYRGPcRyh2b3fkqQmyXc07beY1rNkEkbKXxns94N0UA=; b=UW7aY9AKzT+C+V7q2Mu8sABUTAFBS7FQdYoYYJ2lbK49qxIKnBvhOYnLhPKpE9qz0t Ji8p67Rctmb+5pDMCBpEQzwCUBvBXgy2Vy/+lhISKOSw3TaV2BAm+gQy5jINptllHZom z3aJzqDm5BPWv2N11sfRp4TrRKt2s4n/e2fUNNBG+/7IIAwc2l7mBsFFKmHz5xnukZ/J 7j0Lfi/pJFQoGxuHQEiK1aFh19IUfubB25XrHfL73EPXbQJhBeL6JLR8rocpjLRgkeiP T2ahUD9xAZh6VG1ZiX1cKC8YlZzpbPYQGt4ITnKfOgdqWwNO+GEsNOXb0MBKNumByS9h 6ufQ== X-Gm-Message-State: AOJu0YzWkMsagXCOa0YGYpu/5mLRpeel1uzx40fI1KlD8LiTmQU4fuH3 1oFJmwKdk+Z5uVYWjXIlaQ== X-Google-Smtp-Source: AGHT+IEbpkkUwMS8m0HRQeTKdMYwXj4e9rjshafhVsgnG4tRletjT6wKTUFDB5opO1qLTOQnh19aYQ== X-Received: by 2002:a05:6808:23cb:b0:3b6:d617:a6f7 with SMTP id bq11-20020a05680823cb00b003b6d617a6f7mr539897oib.3.1699648970928; Fri, 10 Nov 2023 12:42:50 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id x26-20020a54401a000000b003b2e3e0284fsm42223oie.53.2023.11.10.12.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:42:50 -0800 (PST) Received: (nullmailer pid 397808 invoked by uid 1000); Fri, 10 Nov 2023 20:42:48 -0000 Date: Fri, 10 Nov 2023 14:42:48 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, Sylwester Nawrocki , linux-mmc@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Greg Kroah-Hartman , Jiri Slaby , Andi Shyti , Alessandro Zummo , Conor Dooley , Mark Brown , Thomas Zimmermann , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sam Protsenko , Alim Akhtar , Liam Girdwood , linux-pwm@vger.kernel.org, Daniel Vetter , David Airlie , Thierry Reding , Rob Herring , Lars-Peter Clausen , Jonathan Cameron , linux-sound@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Maarten Lankhorst , Linus Walleij , linux-samsung-soc@vger.kernel.org, Tomasz Figa , alsa-devel@alsa-project.org, Alexandre Belloni , linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, Krzysztof Kozlowski , Ulf Hansson , Lee Jones , Jaehoon Chung , dri-devel@lists.freedesktop.org, Maxime Ripard , linux-rtc@vger.kernel.org Subject: Re: [PATCH 10/17] dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC Message-ID: <169964896802.397769.16770997428730838541.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_124251_690494_61FE5AF5 X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 08 Nov 2023 11:43:36 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71693C4167D for ; Fri, 10 Nov 2023 20:42:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E962210E10B; Fri, 10 Nov 2023 20:42:53 +0000 (UTC) Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id B385810E10B for ; Fri, 10 Nov 2023 20:42:51 +0000 (UTC) Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3b3e13fc1f7so1412083b6e.0 for ; Fri, 10 Nov 2023 12:42:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648971; x=1700253771; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EYRGPcRyh2b3fkqQmyXc07beY1rNkEkbKXxns94N0UA=; b=q4+lIOi2rLLqGhHlVOITSnX/6TcdG4FFzNKNTMSQhXuLFWVpEnJMTap7Kx1UTT4qWu LYv05gTykzyHNdAhqnPdrrTo+Xo1U6muUtXSp7eSwPBwUqx9kiEZ4nGQHUpmTpKsmB7z YG21JVotZv4uJRCSDJzcyjhZ+6ezftc177nowmzj5NPQzt5qmEQrw7hv+sE1VKeYL6wX +nRU4q67fXImw20D6pqNqBUh17IbUDCgFhBkXpw5JvAxyu1fKHK9JkuRYVsaKlXYp2OL VKm2vD+sA+o7Ie2WDVoG6EIiAj8mzaIuUG7qmt15u3ZlpjrqTVv9d1Z4j+dSMG0YgA3X 6Ndg== X-Gm-Message-State: AOJu0Yzw9XW0i+GOiCmVekN7hKxv7i8rgM5C4dFjZvE0LcGS0wq3UKbe 296PT4xHzP23EyURcfAIOw== X-Google-Smtp-Source: AGHT+IEbpkkUwMS8m0HRQeTKdMYwXj4e9rjshafhVsgnG4tRletjT6wKTUFDB5opO1qLTOQnh19aYQ== X-Received: by 2002:a05:6808:23cb:b0:3b6:d617:a6f7 with SMTP id bq11-20020a05680823cb00b003b6d617a6f7mr539897oib.3.1699648970928; Fri, 10 Nov 2023 12:42:50 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id x26-20020a54401a000000b003b2e3e0284fsm42223oie.53.2023.11.10.12.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:42:50 -0800 (PST) Received: (nullmailer pid 397808 invoked by uid 1000); Fri, 10 Nov 2023 20:42:48 -0000 Date: Fri, 10 Nov 2023 14:42:48 -0600 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH 10/17] dt-bindings: iio: samsung, exynos-adc: add specific compatibles for existing SoC Message-ID: <169964896802.397769.16770997428730838541.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Alim Akhtar , Alexandre Belloni , linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, Tomasz Figa , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-i2c@vger.kernel.org, Sylwester Nawrocki , linux-rtc@vger.kernel.org, Krzysztof Kozlowski , Jiri Slaby , Lee Jones , Jaehoon Chung , linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Ulf Hansson , devicetree@vger.kernel.org, Conor Dooley , Andi Shyti , linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, Mark Brown , Maxime Ripard , Sam Protsenko , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, Liam Girdwood , Rob Herring , Thomas Zimmermann , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 08 Nov 2023 11:43:36 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > Acked-by: Rob Herring