All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Teddy Astie" <teddy.astie@vates.tech>,
	"Roger Pau Monné" <roger@xenproject.org>
Subject: [PATCH] x86/HVM: off-by-1 in new XEN_DOMCTL_ioport_mapping checks
Date: Tue, 17 Nov 2026 16:41:07 +0100	[thread overview]
Message-ID: <16aeb337-d6f3-4f3f-abcf-56fb6340fc6b@suse.com> (raw)

The new checking introduced not so long ago would wrongly reject exactly
adjacent regions.

Fixes: fa61af950bb4 ("x86/HVM: more checking for XEN_DOMCTL_ioport_mapping")
Reported-by: Roger Pau Monné <roger.pau@amd.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -756,8 +756,8 @@ long arch_do_domctl(
                     found = 1;
                     break;
                 }
-                if ( fmp + np >= g2m_ioport->mport &&
-                     g2m_ioport->mport + g2m_ioport->np >= fmp )
+                if ( fmp + np > g2m_ioport->mport &&
+                     g2m_ioport->mport + g2m_ioport->np > fmp )
                 {
                     ret = -EBUSY;
                     break;


             reply	other threads:[~2026-11-17 15:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 15:41 Jan Beulich [this message]
2026-11-17 15:51 ` [PATCH] x86/HVM: off-by-1 in new XEN_DOMCTL_ioport_mapping checks Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16aeb337-d6f3-4f3f-abcf-56fb6340fc6b@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger@xenproject.org \
    --cc=teddy.astie@vates.tech \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.