From: Jan Beulich <jbeulich@suse.com>
To: "Edwin Török" <edwin.torok@citrix.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 1/5] README: update minimum make to 4.1
Date: Tue, 31 Mar 2026 08:14:31 +0200 [thread overview]
Message-ID: <16b415a9-b74f-4afe-a14f-e9d2df704eb9@suse.com> (raw)
In-Reply-To: <4bbe4e23abcd5b1b32204d391bdd593205b89201.1774886602.git.edwin.torok@citrix.com>
On 30.03.2026 18:17, Edwin Török wrote:
> Using .DEFAULT_GOAL requires at least GNU make 3.81.
> It was suggested to update make to match ~2015 era gcc/binutils, hence
> 4.1.
>
> Signed-off-by: Edwin Török <edwin.torok@citrix.com>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Link: https://lore.kernel.org/xen-devel/c0ba57bb-0d86-4209-b019-daf8328b5205@suse.com/
Unless we're specifically meaning to use 4.1 features, personally I'd prefer
the lower 4.0 (which is what I have on my main dev workstation).
Also, nit: Tags in chronological order, please.
Jan
> --- a/README
> +++ b/README
> @@ -35,7 +35,7 @@ Second, there are a number of prerequisites for building a Xen source
> release. Make sure you have all the following installed, either by
> visiting the project webpage or installing a pre-built package
> provided by your OS distributor:
> - * GNU Make v3.80 or later
> + * GNU Make v4.1 or later
> * C compiler and linker:
> - For x86:
> - GCC 5.1 or later
next prev parent reply other threads:[~2026-03-31 6:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 16:17 [PATCH v1 0/5] run unit tests in the CI Edwin Török
2026-03-30 16:17 ` [PATCH v1 1/5] README: update minimum make to 4.1 Edwin Török
2026-03-31 6:14 ` Jan Beulich [this message]
2026-03-31 8:15 ` Edwin Torok
2026-03-31 8:24 ` Jan Beulich
2026-03-31 18:53 ` Edwin Torok
2026-03-30 16:17 ` [PATCH v1 2/5] CI: drop Ubuntu 16.04 Edwin Török
2026-03-31 6:58 ` Jan Beulich
2026-03-31 8:29 ` Edwin Torok
2026-03-31 9:01 ` Jan Beulich
2026-03-30 16:17 ` [PATCH v1 3/5] tools/test: introduce a 'make check' rule Edwin Török
2026-03-31 7:13 ` Jan Beulich
2026-03-30 16:17 ` [PATCH v1 4/5] automation/scripts/build: run unit tests in the CI Edwin Török
2026-03-30 16:17 ` [PATCH v1 5/5] automation/scripts/build: group command output from parallel jobs Edwin Török
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16b415a9-b74f-4afe-a14f-e9d2df704eb9@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=edwin.torok@citrix.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.