All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pavan Kondeti <pavan.kondeti@oss.qualcomm.com>
Cc: hrishabh.rajput@oss.qualcomm.com,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: Add binding for gunyah watchdog
Date: Thu, 4 Sep 2025 12:59:14 +0200	[thread overview]
Message-ID: <16c0d8f4-4a6d-4d65-90ce-34c86ebecfa1@kernel.org> (raw)
In-Reply-To: <af074048-1999-435c-9405-6ffa09eef6dd@kernel.org>

On 04/09/2025 12:49, Krzysztof Kozlowski wrote:
> On 04/09/2025 12:16, Pavan Kondeti wrote:
>>>> +  compatible:
>>>> +    allOf:
>>>> +      - const: gunyah-hypervisor
>>>> +      - const: simple-bus
>>>
>>> What? No.
>>>
>>> Don't create patches with AI.
>>>
>> I am next to Hrishabh when he is writing this patch. I can confirm he
>> did not use AI :-) not sure what tool Krzysztof is using to catch
> 
> My brain?
> 
>> patches being written with AI, that tool needs some improvement for
>> sure. 
> 
> Heh? Seriously, instead replying something like this think from how is
> it possible to come with such syntax?
> 
> It does not exist. NOWHERE.
> 
> It had to be completely hallucinated by AI because I cannot imagine
> coming with code which is completely different then EVERYTHING else.
> There is no single code looking like that.
> 
> 
>>
>> I will let Hrishabh share why he put simple-bus here.
> 
> 
> It is not about simple-bus!
>

And to clarify: it's not only about this part of the binding. Entire
binding is terrible, does not meet any basic standards, does not follow
basic principles of writing DTS. I cannot imagine this code passing
internal review, so hallucinated AI is the most reasonable explanation.
Sorry, if you send extremely poor code using patterns which do not
exist, that;s either huge waste of community time or AI-based waste of
community time.

Best regards,
Krzysztof

  reply	other threads:[~2025-09-04 10:59 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 19:33 [PATCH 0/2] Add support for Gunyah Watchdog Hrishabh Rajput
2025-09-03 19:33 ` Hrishabh Rajput via B4 Relay
2025-09-03 19:33 ` [PATCH 1/2] dt-bindings: Add binding for gunyah watchdog Hrishabh Rajput
2025-09-03 19:33   ` Hrishabh Rajput via B4 Relay
2025-09-03 23:27   ` Rob Herring (Arm)
2025-09-04  9:52   ` Krzysztof Kozlowski
2025-09-04 10:16     ` Pavan Kondeti
2025-09-04 10:49       ` Krzysztof Kozlowski
2025-09-04 10:59         ` Krzysztof Kozlowski [this message]
2025-09-04 12:29           ` Pavan Kondeti
2025-09-04 13:07     ` Hrishabh Rajput
2025-09-04 13:17       ` Krzysztof Kozlowski
2025-09-04 19:03         ` Hrishabh Rajput
2025-09-03 19:34 ` [PATCH 2/2] watchdog: Add driver for Gunyah Watchdog Hrishabh Rajput
2025-09-03 19:34   ` Hrishabh Rajput via B4 Relay
2025-09-03 20:13   ` Bjorn Andersson
2025-09-04 11:40     ` Hrishabh Rajput
2025-09-04 13:47       ` Bjorn Andersson
2025-09-04 17:11   ` Pavan Kondeti
2025-09-05  9:19     ` Konrad Dybcio
2025-09-04  0:10 ` [PATCH 0/2] Add support " Rob Herring
2025-09-04 11:31   ` Konrad Dybcio
2025-09-04 22:51     ` Rob Herring
2025-09-05  0:00       ` Pavan Kondeti
2025-09-05 10:18         ` Konrad Dybcio
2025-09-08  5:49           ` Pavan Kondeti
2025-09-12 11:16             ` Konrad Dybcio
2025-09-04 14:39   ` Hrishabh Rajput
2025-09-04  7:13 ` Neil Armstrong
2025-09-04  9:18   ` Pavan Kondeti
2025-09-04 13:53     ` Bjorn Andersson
2025-09-04 17:05       ` Pavan Kondeti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16c0d8f4-4a6d-4d65-90ce-34c86ebecfa1@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hrishabh.rajput@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=pavan.kondeti@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.