From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Li Subject: Re: [PATCH] drm/rockchip: analogix_dp: add supports for regulators in edp IP Date: Fri, 28 Oct 2016 17:29:15 +0800 Message-ID: <16dfbe16-eae7-8da9-4108-07e623210d35@rock-chips.com> References: <1477163933-13140-1-git-send-email-ayaka@soulik.info> <6d050f06-996f-5ecc-20f9-587299ee34c7@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <6d050f06-996f-5ecc-20f9-587299ee34c7@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Shawn Lin , Randy Li , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org CgpPbiAxMC8yOC8yMDE2IDA1OjExIFBNLCBTaGF3biBMaW4gd3JvdGU6Cj4gT24gMjAxNi8xMC8y MyAzOjE4LCBSYW5keSBMaSB3cm90ZToKPj4gSSBmb3VuZCBpZiBlRFBfQVZERF8xVjAgYW5kIGVE UF9BVkREXzFWOCBhcmUgbm90IGJlZW4gcG93ZXIgYXQKPj4gUkszMjg4LCBvbmNlIHRyeWluZyB0 byBlbmFibGUgdGhlIHBjbGsgY2xvY2ssIHRoZSBrZXJuZWwgd291bGQgZGVhZC4KPj4gVGhpcyBw YXRjaCB3b3VsZCB0cnkgdG8gZW5hYmxlIHRoZW0gZmlyc3QuIFRoZSBlRFBfQVZERF8xVjggbW9y ZQo+PiBsaWtlbHkgdG8gYmUgYXBwbGllZCB0byBlRFAgcGh5LCBidXQgSSBoYXZlIG5vIHRpbWUg dG8gY29uZmlybWVkCj4+IGl0IHlldC4KPgo+IENvbWZpcm0gaXQgb3IgYXQgbGVhc3Qgc29tZW9u ZSBzaG91bGQgYmUgYWJsZSB0byBhbnN3ZXIgeW91cgo+IHF1ZXN0aW9uLCBNYXJrPwpJIGp1c3Qg Zm9yZ2V0IHRvIGFzayB0aGUgSUMgZGVwYXJ0bWVudCwgdGhlIFRSTSBkaWRuJ3QgY292ZXIgdGhh dC4KPgo+IEhhdmUgeW91IGNvbnNpZGVyZWQgdG8gYWRkIHNvbWUgZGV0YWlscyBhYm91dCB2Y2Mt c3VwcGx5IGFuZCB2Y2Npby0KPiBzdXBwbHkgZm9yIHlvdXIgYW5hbG9naXhfZHAtcm9ja2NoaXAu dHh0ID8KPgo+IEZyb20geW91ciBjb21taXQgbXNnLCB0aGVzZSB0d28gcHJvcGVydGllcyBhcmUg bW9yZSBsaWtlbHkgdG8gYmUKPiByZXF1aXJlZCBidXQgdGhlIGNvZGUgaXRzZWxmIHRlbGwgbWUg dGhlbSBzaG91bGQgYmUgb3B0aW9uYWwoZnJvbSB0aGUKPiBwb2ludCBvZiBiYWNrd2FyZCBjb21w YXRpYmlsaXR5LCBpdCBzaG91bGQgYWxzbyBiZSBvcHRpbm9hbCkuClllcywgSSBrZWVwIGl0IG9w dGlvbmFsIGZvciB0aGUgc2FtZSByZWFzb24uIE1vc3Qgb2YgYm9hcmRzIHdvbid0IHR1cm4gCm9m ZiB0aG9zZSBwb3dlciBzdXBwbHkgYW5kIG1heSB1c2Ugc29tZSBmaXhlZCByZWd1bGF0b3JzLgo+ Cj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFJhbmR5IExpIDxheWFrYUBzb3VsaWsuaW5mbz4KPj4gLS0t Cj4+ICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvYW5hbG9naXhfZHAtcm9ja2NoaXAuYyB8IDI1 Cj4+ICsrKysrKysrKysrKysrKysrKysrKysrKysKPj4gIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNl cnRpb25zKCspCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvYW5h bG9naXhfZHAtcm9ja2NoaXAuYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9hbmFsb2dp eF9kcC1yb2NrY2hpcC5jCj4+IGluZGV4IDg1NDhlODIuLjZiZjA0NDEgMTAwNjQ0Cj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC5jCj4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC5jCj4+IEBAIC0x Nyw2ICsxNyw3IEBACj4+ICAjaW5jbHVkZSA8bGludXgvb2ZfZGV2aWNlLmg+Cj4+ICAjaW5jbHVk ZSA8bGludXgvb2ZfZ3JhcGguaD4KPj4gICNpbmNsdWRlIDxsaW51eC9yZWdtYXAuaD4KPj4gKyNp bmNsdWRlIDxsaW51eC9yZWd1bGF0b3IvY29uc3VtZXIuaD4KPj4gICNpbmNsdWRlIDxsaW51eC9y ZXNldC5oPgo+PiAgI2luY2x1ZGUgPGxpbnV4L2Nsay5oPgo+Pgo+PiBAQCAtNzAsNiArNzEsNyBA QCBzdHJ1Y3Qgcm9ja2NoaXBfZHBfZGV2aWNlIHsKPj4gICAgICBzdHJ1Y3QgY2xrICAgICAgICAg ICAgICAgKmdyZmNsazsKPj4gICAgICBzdHJ1Y3QgcmVnbWFwICAgICAgICAgICAgKmdyZjsKPj4g ICAgICBzdHJ1Y3QgcmVzZXRfY29udHJvbCAgICAgKnJzdDsKPj4gKyAgICBzdHJ1Y3QgcmVndWxh dG9yX2J1bGtfZGF0YSBzdXBwbGllc1syXTsKPj4KPj4gICAgICBzdHJ1Y3Qgd29ya19zdHJ1Y3Qg ICAgIHBzcl93b3JrOwo+PiAgICAgIHNwaW5sb2NrX3QgICAgICAgICBwc3JfbG9jazsKPj4gQEAg LTE0Niw2ICsxNDgsMTMgQEAgc3RhdGljIGludCByb2NrY2hpcF9kcF9wb3dlcm9uKHN0cnVjdAo+ PiBhbmFsb2dpeF9kcF9wbGF0X2RhdGEgKnBsYXRfZGF0YSkKPj4KPj4gICAgICBjYW5jZWxfd29y a19zeW5jKCZkcC0+cHNyX3dvcmspOwo+Pgo+PiArICAgIHJldCA9IHJlZ3VsYXRvcl9idWxrX2Vu YWJsZShBUlJBWV9TSVpFKGRwLT5zdXBwbGllcyksCj4+ICsgICAgICAgICAgICBkcC0+c3VwcGxp ZXMpOwo+PiArICAgIGlmIChyZXQpIHsKPj4gKyAgICAgICAgZGV2X2VycihkcC0+ZGV2LCAiZmFp bGVkIHRvIGVuYWJsZSB2ZGQgc3VwcGx5ICVkXG4iLCByZXQpOwo+PiArICAgICAgICByZXR1cm4g cmV0Owo+PiArICAgIH0KPj4gKwo+PiAgICAgIHJldCA9IGNsa19wcmVwYXJlX2VuYWJsZShkcC0+ cGNsayk7Cj4+ICAgICAgaWYgKHJldCA8IDApIHsKPj4gICAgICAgICAgZGV2X2VycihkcC0+ZGV2 LCAiZmFpbGVkIHRvIGVuYWJsZSBwY2xrICVkXG4iLCByZXQpOwo+PiBAQCAtMTY4LDYgKzE3Nyw5 IEBAIHN0YXRpYyBpbnQgcm9ja2NoaXBfZHBfcG93ZXJkb3duKHN0cnVjdAo+PiBhbmFsb2dpeF9k cF9wbGF0X2RhdGEgKnBsYXRfZGF0YSkKPj4KPj4gICAgICBjbGtfZGlzYWJsZV91bnByZXBhcmUo ZHAtPnBjbGspOwo+Pgo+PiArICAgIHJlZ3VsYXRvcl9idWxrX2Rpc2FibGUoQVJSQVlfU0laRShk cC0+c3VwcGxpZXMpLAo+PiArICAgICAgICAgICAgZHAtPnN1cHBsaWVzKTsKPj4gKwo+PiAgICAg IHJldHVybiAwOwo+PiAgfQo+Pgo+PiBAQCAtMzIzLDYgKzMzNSwxOSBAQCBzdGF0aWMgaW50IHJv Y2tjaGlwX2RwX2luaXQoc3RydWN0Cj4+IHJvY2tjaGlwX2RwX2RldmljZSAqZHApCj4+ICAgICAg ICAgIHJldHVybiBQVFJfRVJSKGRwLT5yc3QpOwo+PiAgICAgIH0KPj4KPj4gKyAgICBkcC0+c3Vw cGxpZXNbMF0uc3VwcGx5ID0gInZjYyI7Cj4+ICsgICAgZHAtPnN1cHBsaWVzWzFdLnN1cHBseSA9 ICJ2Y2NpbyI7Cj4+ICsgICAgcmV0ID0gZGV2bV9yZWd1bGF0b3JfYnVsa19nZXQoZGV2LCBBUlJB WV9TSVpFKGRwLT5zdXBwbGllcyksCj4+ICsgICAgICAgICAgICBkcC0+c3VwcGxpZXMpOwo+PiAr ICAgIGlmIChyZXQgPCAwKSB7Cj4+ICsgICAgICAgIGRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIGdl dCByZWd1bGF0b3JzOiAlZFxuIiwgcmV0KTsKPj4gKyAgICB9Cj4+ICsgICAgcmV0ID0gcmVndWxh dG9yX2J1bGtfZW5hYmxlKEFSUkFZX1NJWkUoZHAtPnN1cHBsaWVzKSwKPj4gKyAgICAgICAgICAg IGRwLT5zdXBwbGllcyk7Cj4+ICsgICAgaWYgKHJldCA8IDApIHsKPj4gKyAgICAgICAgZGV2X2Vy cihkZXYsICJmYWlsZWQgdG8gZW5hYmxlIHJlZ3VsYXRvcnM6ICVkXG4iLCByZXQpOwo+PiArICAg IH0KPj4gKwo+PiAgICAgIHJldCA9IGNsa19wcmVwYXJlX2VuYWJsZShkcC0+cGNsayk7Cj4+ICAg ICAgaWYgKHJldCA8IDApIHsKPj4gICAgICAgICAgZGV2X2VycihkcC0+ZGV2LCAiZmFpbGVkIHRv IGVuYWJsZSBwY2xrICVkXG4iLCByZXQpOwo+Pgo+Cj4KCi0tIApSYW5keSBMaQpUaGUgdGhpcmQg cHJvZHVjZSBkZXBhcnRtZW50Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpUaGlzIGVtYWlsIG1lc3NhZ2Us IGluY2x1ZGluZyBhbnkgYXR0YWNobWVudHMsIGlzIGZvciB0aGUgc29sZQp1c2Ugb2YgdGhlIGlu dGVuZGVkIHJlY2lwaWVudChzKSBhbmQgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFsIGFuZApwcml2 aWxlZ2VkIGluZm9ybWF0aW9uLiBBbnkgdW5hdXRob3JpemVkIHJldmlldywgdXNlLCBkaXNjbG9z dXJlIG9yCmRpc3RyaWJ1dGlvbiBpcyBwcm9oaWJpdGVkLiBJZiB5b3UgYXJlIG5vdCB0aGUgaW50 ZW5kZWQgcmVjaXBpZW50LCBwbGVhc2UKY29udGFjdCB0aGUgc2VuZGVyIGJ5IHJlcGx5IGUtbWFp bCBhbmQgZGVzdHJveSBhbGwgY29waWVzIG9mIHRoZSBvcmlnaW5hbAptZXNzYWdlLiBbRnV6aG91 IFJvY2tjaGlwIEVsZWN0cm9uaWNzLCBJTkMuIENoaW5hIG1haW5sYW5kXQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: randy.li@rock-chips.com (Randy Li) Date: Fri, 28 Oct 2016 17:29:15 +0800 Subject: [PATCH] drm/rockchip: analogix_dp: add supports for regulators in edp IP In-Reply-To: <6d050f06-996f-5ecc-20f9-587299ee34c7@rock-chips.com> References: <1477163933-13140-1-git-send-email-ayaka@soulik.info> <6d050f06-996f-5ecc-20f9-587299ee34c7@rock-chips.com> Message-ID: <16dfbe16-eae7-8da9-4108-07e623210d35@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/28/2016 05:11 PM, Shawn Lin wrote: > On 2016/10/23 3:18, Randy Li wrote: >> I found if eDP_AVDD_1V0 and eDP_AVDD_1V8 are not been power at >> RK3288, once trying to enable the pclk clock, the kernel would dead. >> This patch would try to enable them first. The eDP_AVDD_1V8 more >> likely to be applied to eDP phy, but I have no time to confirmed >> it yet. > > Comfirm it or at least someone should be able to answer your > question, Mark? I just forget to ask the IC department, the TRM didn't cover that. > > Have you considered to add some details about vcc-supply and vccio- > supply for your analogix_dp-rockchip.txt ? > > From your commit msg, these two properties are more likely to be > required but the code itself tell me them should be optional(from the > point of backward compatibility, it should also be optinoal). Yes, I keep it optional for the same reason. Most of boards won't turn off those power supply and may use some fixed regulators. > >> >> Signed-off-by: Randy Li >> --- >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 25 >> +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> index 8548e82..6bf0441 100644 >> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> @@ -17,6 +17,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> >> @@ -70,6 +71,7 @@ struct rockchip_dp_device { >> struct clk *grfclk; >> struct regmap *grf; >> struct reset_control *rst; >> + struct regulator_bulk_data supplies[2]; >> >> struct work_struct psr_work; >> spinlock_t psr_lock; >> @@ -146,6 +148,13 @@ static int rockchip_dp_poweron(struct >> analogix_dp_plat_data *plat_data) >> >> cancel_work_sync(&dp->psr_work); >> >> + ret = regulator_bulk_enable(ARRAY_SIZE(dp->supplies), >> + dp->supplies); >> + if (ret) { >> + dev_err(dp->dev, "failed to enable vdd supply %d\n", ret); >> + return ret; >> + } >> + >> ret = clk_prepare_enable(dp->pclk); >> if (ret < 0) { >> dev_err(dp->dev, "failed to enable pclk %d\n", ret); >> @@ -168,6 +177,9 @@ static int rockchip_dp_powerdown(struct >> analogix_dp_plat_data *plat_data) >> >> clk_disable_unprepare(dp->pclk); >> >> + regulator_bulk_disable(ARRAY_SIZE(dp->supplies), >> + dp->supplies); >> + >> return 0; >> } >> >> @@ -323,6 +335,19 @@ static int rockchip_dp_init(struct >> rockchip_dp_device *dp) >> return PTR_ERR(dp->rst); >> } >> >> + dp->supplies[0].supply = "vcc"; >> + dp->supplies[1].supply = "vccio"; >> + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(dp->supplies), >> + dp->supplies); >> + if (ret < 0) { >> + dev_err(dev, "failed to get regulators: %d\n", ret); >> + } >> + ret = regulator_bulk_enable(ARRAY_SIZE(dp->supplies), >> + dp->supplies); >> + if (ret < 0) { >> + dev_err(dev, "failed to enable regulators: %d\n", ret); >> + } >> + >> ret = clk_prepare_enable(dp->pclk); >> if (ret < 0) { >> dev_err(dp->dev, "failed to enable pclk %d\n", ret); >> > > -- Randy Li The third produce department =========================================================================== This email message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message. [Fuzhou Rockchip Electronics, INC. China mainland] =========================================================================== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758076AbcJ1J3p (ORCPT ); Fri, 28 Oct 2016 05:29:45 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:33335 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126AbcJ1J3o (ORCPT ); Fri, 28 Oct 2016 05:29:44 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: randy.li@rock-chips.com X-FST-TO: mark.yao@rock-chips.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: randy.li@rock-chips.com X-UNIQUE-TAG: <1d14c56e26c6c124099a93c11fe2126d> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: analogix_dp: add supports for regulators in edp IP To: Shawn Lin , Randy Li , dri-devel@lists.freedesktop.org References: <1477163933-13140-1-git-send-email-ayaka@soulik.info> <6d050f06-996f-5ecc-20f9-587299ee34c7@rock-chips.com> Cc: heiko@sntech.de, airlied@linux.ie, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com From: Randy Li Organization: Fuzhou Rockchip Message-ID: <16dfbe16-eae7-8da9-4108-07e623210d35@rock-chips.com> Date: Fri, 28 Oct 2016 17:29:15 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <6d050f06-996f-5ecc-20f9-587299ee34c7@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28/2016 05:11 PM, Shawn Lin wrote: > On 2016/10/23 3:18, Randy Li wrote: >> I found if eDP_AVDD_1V0 and eDP_AVDD_1V8 are not been power at >> RK3288, once trying to enable the pclk clock, the kernel would dead. >> This patch would try to enable them first. The eDP_AVDD_1V8 more >> likely to be applied to eDP phy, but I have no time to confirmed >> it yet. > > Comfirm it or at least someone should be able to answer your > question, Mark? I just forget to ask the IC department, the TRM didn't cover that. > > Have you considered to add some details about vcc-supply and vccio- > supply for your analogix_dp-rockchip.txt ? > > From your commit msg, these two properties are more likely to be > required but the code itself tell me them should be optional(from the > point of backward compatibility, it should also be optinoal). Yes, I keep it optional for the same reason. Most of boards won't turn off those power supply and may use some fixed regulators. > >> >> Signed-off-by: Randy Li >> --- >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 25 >> +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> index 8548e82..6bf0441 100644 >> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c >> @@ -17,6 +17,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> >> @@ -70,6 +71,7 @@ struct rockchip_dp_device { >> struct clk *grfclk; >> struct regmap *grf; >> struct reset_control *rst; >> + struct regulator_bulk_data supplies[2]; >> >> struct work_struct psr_work; >> spinlock_t psr_lock; >> @@ -146,6 +148,13 @@ static int rockchip_dp_poweron(struct >> analogix_dp_plat_data *plat_data) >> >> cancel_work_sync(&dp->psr_work); >> >> + ret = regulator_bulk_enable(ARRAY_SIZE(dp->supplies), >> + dp->supplies); >> + if (ret) { >> + dev_err(dp->dev, "failed to enable vdd supply %d\n", ret); >> + return ret; >> + } >> + >> ret = clk_prepare_enable(dp->pclk); >> if (ret < 0) { >> dev_err(dp->dev, "failed to enable pclk %d\n", ret); >> @@ -168,6 +177,9 @@ static int rockchip_dp_powerdown(struct >> analogix_dp_plat_data *plat_data) >> >> clk_disable_unprepare(dp->pclk); >> >> + regulator_bulk_disable(ARRAY_SIZE(dp->supplies), >> + dp->supplies); >> + >> return 0; >> } >> >> @@ -323,6 +335,19 @@ static int rockchip_dp_init(struct >> rockchip_dp_device *dp) >> return PTR_ERR(dp->rst); >> } >> >> + dp->supplies[0].supply = "vcc"; >> + dp->supplies[1].supply = "vccio"; >> + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(dp->supplies), >> + dp->supplies); >> + if (ret < 0) { >> + dev_err(dev, "failed to get regulators: %d\n", ret); >> + } >> + ret = regulator_bulk_enable(ARRAY_SIZE(dp->supplies), >> + dp->supplies); >> + if (ret < 0) { >> + dev_err(dev, "failed to enable regulators: %d\n", ret); >> + } >> + >> ret = clk_prepare_enable(dp->pclk); >> if (ret < 0) { >> dev_err(dp->dev, "failed to enable pclk %d\n", ret); >> > > -- Randy Li The third produce department =========================================================================== This email message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message. [Fuzhou Rockchip Electronics, INC. China mainland] ===========================================================================