From: Jens Axboe <axboe@kernel.dk>
To: sparclinux@vger.kernel.org
Subject: Re: [sparc64] unable to boot git kernel / deadlock / cpu stall
Date: Wed, 02 Jan 2019 15:44:26 +0000 [thread overview]
Message-ID: <16e68c7a-c09b-7b98-a608-e20502ca74b7@kernel.dk> (raw)
In-Reply-To: <CADxRZqwwE5wu6KSvydtEggpdb+5XjNpk+uCeE8vJYp72TCJY=w@mail.gmail.com>
On 1/2/19 5:11 AM, Ming Lei wrote:
>> diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c
>> index 9c0553dd13e7..6eddd17a864a 100644
>> --- a/drivers/block/sunvdc.c
>> +++ b/drivers/block/sunvdc.c
>> @@ -181,7 +181,7 @@ static void vdc_blk_queue_start(struct vdc_port *port)
>> * allocated a disk.
>> */
>> if (port->disk && vdc_tx_dring_avail(dr) * 100 / VDC_TX_RING_SIZE >= 50)
>> - blk_mq_start_hw_queues(port->disk->queue);
>> + blk_mq_start_stopped_hw_queue(port->disk->queue, true);
>> }
>>
>> static void vdc_finish(struct vio_driver_state *vio, int err, int waiting_for)
>
> oops, we should have called blk_mq_start_stopped_hw_queues():
>
> diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c
> index 9c0553dd13e7..ab7f7ab4c472 100644
> --- a/drivers/block/sunvdc.c
> +++ b/drivers/block/sunvdc.c
> @@ -181,7 +181,7 @@ static void vdc_blk_queue_start(struct vdc_port *port)
> * allocated a disk.
> */
> if (port->disk && vdc_tx_dring_avail(dr) * 100 / VDC_TX_RING_SIZE >= 50)
> - blk_mq_start_hw_queues(port->disk->queue);
> + blk_mq_start_stopped_hw_queues(port->disk->queue, true);
> }
>
> static void vdc_finish(struct vio_driver_state *vio, int err, int waiting_for)
Indeed, that was a silly oversight on my part. Ming, will you send a
"proper" patch so I can queue it up?
--
Jens Axboe
prev parent reply other threads:[~2019-01-02 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 10:58 [sparc64] unable to boot git kernel / deadlock / cpu stall Anatoly Pugachev
2019-01-02 12:08 ` Ming Lei
2019-01-02 12:11 ` Ming Lei
2019-01-02 14:34 ` Anatoly Pugachev
2019-01-02 15:44 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e68c7a-c09b-7b98-a608-e20502ca74b7@kernel.dk \
--to=axboe@kernel.dk \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.