All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Guchun Chen <guchun.chen-5C7GfCeVMHo@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Hawking.Zhang-5C7GfCeVMHo@public.gmane.org,
	Dennis.Li-5C7GfCeVMHo@public.gmane.org,
	christian.koenig-5C7GfCeVMHo@public.gmane.org,
	alexander.deucher-5C7GfCeVMHo@public.gmane.org,
	Tao.Zhou1-5C7GfCeVMHo@public.gmane.org
Cc: Candice.Li-5C7GfCeVMHo@public.gmane.org
Subject: Re: [PATCH libdrm 0/4] amdgpu: new approach for ras inject test
Date: Thu, 29 Aug 2019 11:03:27 +0200	[thread overview]
Message-ID: <16e80e67-e9eb-4091-d2ea-69255e68bb25@gmail.com> (raw)
In-Reply-To: <20190829085917.20439-1-guchun.chen-5C7GfCeVMHo@public.gmane.org>

Only skimmed over the patches, but in general looks good to me.

Feel free to add an Acked-by: Christian König <christian.koenig@amd.com> 
to the whole series.

But somebody with more ras knowledge than I have should probably take a 
look as well.

Christian.

Am 29.08.19 um 10:59 schrieb Guchun Chen:
> These patches are to remove additional external lib-jsonc
> dependence, and to put all test configurations into C code.
>
> Guchun Chen (4):
>    amdgpu: remove json package dependence
>    amdgpu: delete test configuration file
>    amdgpu: add ras inject unit test
>    amdgpu: add ras feature capability check in inject test
>
>   configure.ac             |  18 ---
>   data/amdgpu_ras.json     | 267 ----------------------------------
>   meson.build              |   1 -
>   tests/amdgpu/Makefile.am |   5 +-
>   tests/amdgpu/meson.build |  16 +-
>   tests/amdgpu/ras_tests.c | 305 ++++++++++++++-------------------------
>   6 files changed, 116 insertions(+), 496 deletions(-)
>   delete mode 100644 data/amdgpu_ras.json
>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-08-29  9:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29  8:59 [PATCH libdrm 0/4] amdgpu: new approach for ras inject test Guchun Chen
     [not found] ` <20190829085917.20439-1-guchun.chen-5C7GfCeVMHo@public.gmane.org>
2019-08-29  8:59   ` [PATCH libdrm 1/4] amdgpu: remove json package dependence Guchun Chen
2019-08-29  8:59   ` [PATCH libdrm 2/4] amdgpu: delete test configuration file Guchun Chen
2019-08-29  8:59   ` [PATCH libdrm 3/4] amdgpu: add ras inject unit test Guchun Chen
2019-08-29  8:59   ` [PATCH libdrm 4/4] amdgpu: add ras feature capability check in inject test Guchun Chen
2019-08-29  9:03   ` Christian König [this message]
2019-08-29  9:26   ` [PATCH libdrm 0/4] amdgpu: new approach for ras " Zhou1, Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16e80e67-e9eb-4091-d2ea-69255e68bb25@gmail.com \
    --to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=Candice.Li-5C7GfCeVMHo@public.gmane.org \
    --cc=Dennis.Li-5C7GfCeVMHo@public.gmane.org \
    --cc=Hawking.Zhang-5C7GfCeVMHo@public.gmane.org \
    --cc=Tao.Zhou1-5C7GfCeVMHo@public.gmane.org \
    --cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=guchun.chen-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.