All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	brcm80211-dev-list.pdl@broadcom.com,
	brcm80211-dev-list@cypress.com
Cc: Aaron Blair <aaron@aaronpb.me>
Subject: Re: brcmfmac: NULL pointer dereference during brcmf_detach() after firmware crash
Date: Thu, 14 Feb 2019 23:36:55 +0100	[thread overview]
Message-ID: <16ea722f-e08d-044f-216c-4ea745cc6344@broadcom.com> (raw)
In-Reply-To: <b519e746-ddfd-421f-d897-7620d229e4b2@gmail.com>

On 2/14/2019 11:30 PM, Rafał Miłecki wrote:
> Hi,
> 
> I've just found a well reproducible brcmfmac crash (NULL pointer 
> dereference).
> 
> Steps:
> 1. Wait for or trigger a FullMAC firmware crash
> 2. Wait for some skb to get queued on a flowring
> 3. Call rmmod brcmfmac
> 
> Problem:
> There is a NULL pointer dereference in one of the brcmf_detach() calls.
> 
> Explanation:
> brcmf_detach() first frees all "ifp"s and then deletes flowrings. If any
> flowring has a skb it results in calling brcmf_txfinalize() which tries
> to access "ifp" (struct brcmf_if) which is a NULL.

Hi Rafał,

Thanks for diving in. That was my suspicion. Does it mean you are 
working on a patch or shall I take care of it.

Regards,
Arend

  reply	other threads:[~2019-02-14 22:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 22:30 brcmfmac: NULL pointer dereference during brcmf_detach() after firmware crash Rafał Miłecki
2019-02-14 22:36 ` Arend Van Spriel [this message]
2019-02-15  6:15   ` Rafał Miłecki
2019-04-18 11:55     ` Rafał Miłecki
2019-04-25  7:17       ` Arend Van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16ea722f-e08d-044f-216c-4ea745cc6344@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=aaron@aaronpb.me \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.