From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C31DC83F01 for ; Wed, 30 Aug 2023 22:30:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239640AbjH3Wat (ORCPT ); Wed, 30 Aug 2023 18:30:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242802AbjH3War (ORCPT ); Wed, 30 Aug 2023 18:30:47 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63EBFD7 for ; Wed, 30 Aug 2023 15:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693434587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FYqfRtnQxOV7PByWJqK8y3BA13qWsYODXL0RRw5z4G0=; b=d4HpOitWxItuK9VDVALoCSuX2uJqGmgDpH3n6go7cxL5+bVo3TKQJ6sNMUiw+Rs0qRVBmQ WsQ9Lrj7v3Lh/FvNKcfmegbUa5Ky9k+P5EhGMM9RhsKAruzTjpxVL2F+6H2ZEYmwWILRxC nJBDobGlnX6ba0+rEvTOK09QfUgPtO8= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664--QmGb92IMa-5RMcHjmKMHA-1; Wed, 30 Aug 2023 18:29:46 -0400 X-MC-Unique: -QmGb92IMa-5RMcHjmKMHA-1 Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-3a842e7ba1cso157134b6e.3 for ; Wed, 30 Aug 2023 15:29:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693434585; x=1694039385; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FYqfRtnQxOV7PByWJqK8y3BA13qWsYODXL0RRw5z4G0=; b=APA5/QwKsInmKcZ0w7q2jZs03BKbnLCLqPQ46apqcsWtP9IiaLhF/hxmLxGYmffflE xrxx7QYBKQwFqSAFIPFE4JpLCJhCms1YBdCEbTLu2fFLNU/hWyIH7NlVTe6c1DtwFoT9 hr1Yb73MufKKRIPecxxmjlvEI+r9LzIghA91wl8f9eiBrPdqposy3DStqlPqX/eyRvod FaGuS8Lv8ukeKJKhRPnije1v94ML42sprYq8vmTrc7CSk0EiVhOayLjFSDU0lYiN1yw6 ZL9yz3pZXtmD0LAEFxje35BtqHUkpaaPXOKzcFsOu9v1gWtpqlooVSqxooeUWm0gQGka 7C1w== X-Gm-Message-State: AOJu0YxcueIYuGDRLIK7m+jvYVU0nL1/e1L2HTB4GIrYq+hE/oIKKTlJ 2lfHK2C4MnhNfMgV5g4wrKNFAOShs0jJvdfb5CSb8+1ankh4oG39g0a+aY4NtbBVSjBytNDHJv2 n8w4dfuQAef9MvU4Zt8nR5bc= X-Received: by 2002:a05:6808:1a04:b0:3a8:4903:5688 with SMTP id bk4-20020a0568081a0400b003a849035688mr3505573oib.34.1693434585742; Wed, 30 Aug 2023 15:29:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqqemKSM9xURwBZYJlx1jyubOYrTVHwKDb0ZiV7TlN0z/vk4Ihpk00JCwFASj9ui/sEfBJew== X-Received: by 2002:a05:6808:1a04:b0:3a8:4903:5688 with SMTP id bk4-20020a0568081a0400b003a849035688mr3505558oib.34.1693434585554; Wed, 30 Aug 2023 15:29:45 -0700 (PDT) Received: from ?IPv6:2804:1b3:a802:98e3:3c98:3d83:9703:4411? ([2804:1b3:a802:98e3:3c98:3d83:9703:4411]) by smtp.gmail.com with ESMTPSA id a10-20020a544e0a000000b003a8560a9d34sm67503oiy.25.2023.08.30.15.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Aug 2023 15:29:45 -0700 (PDT) Message-ID: <16efceed0b215ee34cc46ca7bba4a86bcf2d8ad7.camel@redhat.com> Subject: Re: [RFC PATCH v2 0/3] Move usages of struct __call_single_data to call_single_data_t From: Leonardo =?ISO-8859-1?Q?Br=E1s?= To: Chengming Zhou , Jens Axboe , Peter Zijlstra , Josh Poimboeuf , Palmer Dabbelt , Guo Ren , Valentin Schneider , "Paul E. McKenney" , Juergen Gross , Yury Norov , Marcelo Tosatti Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 30 Aug 2023 19:29:40 -0300 In-Reply-To: <51cf9db1-4487-4229-4d43-e91268e52125@linux.dev> References: <20230520052957.798486-1-leobras@redhat.com> <1cd98cb37dcf621520e52ac7a15513aab5749534.camel@redhat.com> <51cf9db1-4487-4229-4d43-e91268e52125@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, 2023-08-29 at 10:29 +0800, Chengming Zhou wrote: > On 2023/8/29 08:55, Leonardo Br=C3=A1s wrote: > > On Tue, 2023-07-04 at 04:22 -0300, Leonardo Br=C3=A1s wrote: > > > On Tue, 2023-06-13 at 00:51 -0300, Leonardo Bras Soares Passos wrote: > > > > Friendly ping > > > >=20 > > > > On Sat, May 20, 2023 at 2:30=E2=80=AFAM Leonardo Bras wrote: > > > > >=20 > > > > > Changes since RFCv1: > > > > > - request->csd moved to the middle of the struct, without size im= pact > > > > > - type change happens in a different patch (thanks Jens Axboe!) > > > > > - Improved the third patch to also update the .h file. > > > > >=20 > > > > > Leonardo Bras (3): > > > > > blk-mq: Move csd inside struct request so it's 32-byte aligned > > > > > blk-mq: Change request->csd type to call_single_data_t > > > > > smp: Change signatures to use call_single_data_t > > > > >=20 > > > > > include/linux/blk-mq.h | 10 +++++----- > > > > > include/linux/smp.h | 2 +- > > > > > kernel/smp.c | 4 ++-- > > > > > kernel/up.c | 2 +- > > > > > 4 files changed, 9 insertions(+), 9 deletions(-) > > > > >=20 > > > > > -- > > > > > 2.40.1 > > > > >=20 > > >=20 > > > Hello Jens, > > >=20 > > > I still want your feedback on this series :) > > >=20 > > > I think I addressed every issue of RFCv1, but if you have any other f= eedback, > > > please let me know. > > >=20 > > > Thanks! > > > Leo > >=20 > > Hello Jens Axboe, > >=20 > > Please provide feedback on this series! > >=20 > > Are you ok with those changes? > > What's your opinion on them?=20 > >=20 > > Thanks! > > Leo > >=20 >=20 > Hello, >=20 > FYI, there is no csd in struct request anymore in block/for-next branch, > which is deleted by this commit: >=20 > commit 660e802c76c89e871c29cd3174c07c8d23e39c35 > Author: Chengming Zhou > Date: Mon Jul 17 12:00:55 2023 +0800 >=20 > blk-mq: use percpu csd to remote complete instead of per-rq csd >=20 > If request need to be completed remotely, we insert it into percpu ll= ist, > and smp_call_function_single_async() if llist is empty previously. >=20 > We don't need to use per-rq csd, percpu csd is enough. And the size o= f > struct request is decreased by 24 bytes. >=20 > This way is cleaner, and looks correct, given block softirq is guaran= teed > to be scheduled to consume the list if one new request is added to th= is > percpu list, either smp_call_function_single_async() returns -EBUSY o= r 0. >=20 > Signed-off-by: Chengming Zhou > Reviewed-by: Ming Lei > Reviewed-by: Christoph Hellwig > Link: https://lore.kernel.org/r/20230717040058.3993930-2-chengming.zh= ou@linux.dev > Signed-off-by: Jens Axboe >=20 Oh, thanks for the heads-up! I will send reviewed version of patch 3. I suppose it can go on top of block/for-next, since the above patch is ther= e. Does that work for you Jens Axboe? Thanks! Leo