From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Bjorn Andersson" <andersson@kernel.org>,
"Abel Vesa" <abelvesa@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/3] platform: arm64: Add a driver for the EC found on ASUS Glymur machines
Date: Fri, 18 Sep 2026 14:21:30 +0200 [thread overview]
Message-ID: <16f52fbf-1e24-42d9-9f04-d0829b930276@kernel.org> (raw)
In-Reply-To: <002eb70b-17fe-496d-870f-ac15c62fe32e@oss.qualcomm.com>
On 18/09/2026 14:18, Konrad Dybcio wrote:
>>> +
>>> +static const struct of_device_id asus_glymur_ec_of_match[] = {
>>> + { .compatible = "asus,zenbook-a14-ux3407na-ec" },
>>> + { .compatible = "asus,zenbook-a16-ux3607oa-ec" },
>>
>> Does this mean devices are compatible? If so should be expressed in the
>> bindings. If not, should be expressed in bindings commit msg, see
>> writing bindings docs.
>
> They generally seem to be, but because of the very limited information
> we have, I don't think it's worth risking associating them.. Would
> a mention of this be enough?
Yes
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-18 12:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 10:54 [PATCH 0/3] Asus Zenbook A16/A14 (UX3607OA/UX3407NA) EC driver Konrad Dybcio
2026-09-17 10:54 ` [PATCH 1/3] dt-bindings: embedded-controller: Add ASUS Zenbook A16 EC Konrad Dybcio
2026-09-17 10:59 ` sashiko-bot
2026-09-18 11:34 ` Krzysztof Kozlowski
2026-09-18 12:29 ` Konrad Dybcio
2026-09-18 13:21 ` Krzysztof Kozlowski
2026-09-18 13:23 ` Konrad Dybcio
2026-09-18 13:38 ` Krzysztof Kozlowski
2026-09-17 10:54 ` [PATCH 2/3] platform: arm64: Add a driver for the EC found on ASUS Glymur machines Konrad Dybcio
2026-09-17 11:03 ` sashiko-bot
2026-09-18 11:35 ` Krzysztof Kozlowski
2026-09-18 12:18 ` Konrad Dybcio
2026-09-18 12:21 ` Krzysztof Kozlowski [this message]
2026-09-17 10:54 ` [PATCH 3/3] arm64: dts: qcom: glymur-zenbook-a16: Add Embedded Controller Konrad Dybcio
2026-09-17 10:59 ` sashiko-bot
2026-09-17 15:20 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16f52fbf-1e24-42d9-9f04-d0829b930276@kernel.org \
--to=krzk@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.