From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15B19C4167B for ; Wed, 29 Nov 2023 20:15:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bTmN6H9AoQeuMA46WB8iMMSRrsFdOJ1Y0MJWwZB8fYE=; b=mblIrLB7n0j5dY KeBMwsDa++q+uPMFugkg9V/PzyMDXHLl7msPDLycHo3xzNMwEjMO3wPnV1Uw+tvfGXxucIfQUUOwi D2wJc2T/SHaQrbIeKf7J7CDc5LQGza8H2FZfZ+5+vm8PrHt/kMo+Bfx1g+jTQ2mxbSbPopMwvwJxJ ba82ArDiDit1InykLJPuGInTGtmr4gGq4FhO9ZcGe+bDKcmxpz0j7YLllLEBclayGo/1WqcSLUYaj xbliE6/XvvTB7FdMAG3y6OYO13dAvY5F7VmjaqBy7twZfvBI2Qubo5JV0D1g4Z08NQvqxdurwLnrT OoTaWc5odzq8x7aOFWcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8QxN-009EHG-2q; Wed, 29 Nov 2023 20:14:49 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8QxL-009EGx-0A for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 20:14:48 +0000 Received: from pendragon.ideasonboard.com (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9735B6F0; Wed, 29 Nov 2023 21:14:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701288849; bh=uJx2WyhfAxcEwQ+ee41/z9G2InAvJw4jSMa05qDKaAs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=TZ021HKV3henHtehwczYCqsqTxFs1KZRgdIoYtxe64lWfIZh/UwEa3vOWl/1G2spW yt1cy9gKg0as1rKOs5K869+XC4R3yks5V5eFYbFChameoMDnTeJdPvZznKhFGdixRB rTXms0JuWC3kud3Yr5Am3954wtVSGcxSIShacVnw= MIME-Version: 1.0 In-Reply-To: <20231129105536.GE24293@pendragon.ideasonboard.com> References: <20230417055627.16482-1-laurent.pinchart@ideasonboard.com> <20230417055627.16482-2-laurent.pinchart@ideasonboard.com> <20231129105536.GE24293@pendragon.ideasonboard.com> Subject: Re: [PATCH v1 1/2] arm64: dts: imx8mp: Add CSIS DT nodes From: Kieran Bingham Cc: Marco Felsch , Alexander Stein , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, Shawn Guo , Krzysztof Kozlowski , Rob Herring , Jacopo Mondi , Xavier Roumegue To: Adam Ford , Laurent Pinchart Date: Wed, 29 Nov 2023 20:14:42 +0000 Message-ID: <170128888298.3048548.2160913449516998097@ping.linuxembedded.co.uk> User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_121447_257906_D3ED4AD3 X-CRM114-Status: GOOD ( 35.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UXVvdGluZyBMYXVyZW50IFBpbmNoYXJ0ICgyMDIzLTExLTI5IDEwOjU1OjM2KQo+IEhpIEFkYW0s Cj4gCj4gKENDJ2luZyBLaWVyYW4pCj4gCj4gT24gVHVlLCBOb3YgMjgsIDIwMjMgYXQgMDk6MTc6 NTFQTSAtMDYwMCwgQWRhbSBGb3JkIHdyb3RlOgo+ID4gT24gTW9uLCBBcHIgMTcsIDIwMjMgYXQg MTowMeKAr0FNIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiA+Cj4gPiA+IEFkZCBEVCBub2Rl cyBmb3IgdGhlIHR3byBDU0ktMiByZWNlaXZlcnMgb2YgdGhlIGkuTVg4TVAuCj4gPiA+Cj4gPiA+ IFNpZ25lZC1vZmYtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNv bmJvYXJkLmNvbT4KPiA+ID4gLS0tCj4gPiAKPiA+IExhdXJlbnQsCj4gPiAKPiA+IFNvcnJ5IHRv IGRpZyB1cCBhbiBvbGQgdGhyZWFkLCBidXQgSSBoYXZlIGEgY29uY2VybiBhYm91dCB0aGUgY2xv Y2sKPiA+IHJhdGluZ3MgYW5kIG5vbWluYWwgbW9kZSB2cyBvdmVyZHJpdmUgbW9kZS4gIEkgc3Rh cnRlZCBpbnZlc3RpZ2F0aW5nCj4gPiB0aGUgZGlmZmVyZW50IGRhdGEgc2hlZXRzIGFtb25nc3Qg dGhlIHZhcmlvdXMgaW14OG1bbW5wXSBmYW1pbGllcyB0bwo+ID4gbWFrZSB0aGUgZGVmYXVsdCBk ZXZpY2UgdHJlZXMgcnVuIGF0IG5vbWluYWwgbW9kZSB3aGlsZSBhbHNvIGNyZWF0aW5nCj4gPiBh IHNlcGFyYXRlIGR0c2kgZmlsZSB3aXRoIHNldHRpbmdzIGZvciBvdmVyZHJpdmUgc28gYm9hcmRz IHdobyB1c2UgaXQKPiA+IGNhbiBpbmNsdWRlIHRoZW0gd2l0aG91dCBoYXZpbmcgdG8gZHVwbGlj YXRlIHRoZSBjbG9jayBzZXR0aW5ncyBmb3IKPiA+IGV2ZXJ5b25lIHdobyBzdXBwb3J0cyBvdmVy ZHJpdmUuCj4gPiAKPiA+ID4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxlL2lteDhtcC5k dHNpIHwgNjAgKysrKysrKysrKysrKysrKysrKysrKysKPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA2 MCBpbnNlcnRpb25zKCspCj4gPiA+Cj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3Qv ZHRzL2ZyZWVzY2FsZS9pbXg4bXAuZHRzaSBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxl L2lteDhtcC5kdHNpCj4gPiA+IGluZGV4IDJkZDYwZTMyNTJmMy4uMmEzNzRhNGMxNGEyIDEwMDY0 NAo+ID4gPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2ZyZWVzY2FsZS9pbXg4bXAuZHRzaQo+ ID4gPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2ZyZWVzY2FsZS9pbXg4bXAuZHRzaQo+ID4g PiBAQCAtMTIzOSw2ICsxMjM5LDY2IEBAIGxkYl9sdmRzX2NoMTogZW5kcG9pbnQgewo+ID4gPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07Cj4gPiA+ICAgICAgICAgICAgICAgICAg ICAgICAgIH07Cj4gPiA+Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIG1pcGlfY3NpXzA6 IGNzaUAzMmU0MDAwMCB7Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29t cGF0aWJsZSA9ICJmc2wsaW14OG1wLW1pcGktY3NpMiIsICJmc2wsaW14OG1tLW1pcGktY3NpMiI7 Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4MzJlNDAwMDAg MHgxMDAwMD47Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50ZXJydXB0 cyA9IDxHSUNfU1BJIDE3IElSUV9UWVBFX0xFVkVMX0hJR0g+Owo+ID4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGNsb2NrLWZyZXF1ZW5jeSA9IDw1MDAwMDAwMDA+Owo+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmY2xrIElNWDhNUF9DTEtf TUVESUFfQVBCX1JPT1Q+LAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDwmY2xrIElNWDhNUF9DTEtfTUVESUFfQ0FNMV9QSVhfUk9PVD4sCj4gPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPCZjbGsgSU1YOE1QX0NMS19NRURJ QV9NSVBJX1BIWTFfUkVGX1JPT1Q+LAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIDwmY2xrIElNWDhNUF9DTEtfTUVESUFfQVhJX1JPT1Q+Owo+ID4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsb2NrLW5hbWVzID0gInBjbGsiLCAid3JhcCIs ICJwaHkiLCAiYXhpIjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhc3Np Z25lZC1jbG9ja3MgPSA8JmNsayBJTVg4TVBfQ0xLX01FRElBX0NBTTFfUElYPjsKPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhc3NpZ25lZC1jbG9jay1wYXJlbnRzID0gPCZj bGsgSU1YOE1QX1NZU19QTEwyXzEwMDBNPjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBhc3NpZ25lZC1jbG9jay1yYXRlcyA9IDw1MDAwMDAwMDA+Owo+ID4gCj4gPiBBY2Nv cmRpbmcgdG8gUmV2IDIuMSBvZiB0aGUgRGF0YSBzaGVldCAoSU1YOE1QQ0VDKSwgZGF0ZWQgSnVs eSAyMDIzLAo+ID4gNTAwTUh6IGlzIGxpc3RlZCBhcyBzaW5nbGUtY2FtZXJhLCBvdmVyZHJpdmUg bW9kZS4gIFNpbmdsZS1jYW1lcmEsCj4gPiBub21pbmFsIG1vZGUgaXMgNDAwTUh6LCBidXQgdGhl cmUgaXMgbW9yZS4uLgo+ID4gSWYgY29uZmlndXJlZCBmb3IgZHVhbCBjYW1lcmFzLCBib3RoIENT SSBjYW4gb25seSBzdXBwb3J0IHVwIHRvCj4gPiAyNjZNSHosIGJ1dCB3ZSBoYXZlIHBhcnRpYWxs eSBjb25maWd1cmVkIGJvdGggYWxiZWl0IHdpdGhvdXQgdGhlCj4gPiBhY3R1YWwgY2FtZXJhIHNl bnNvcnMgY29ubmVjdGVkLgo+ID4gCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcG93ZXItZG9tYWlucyA9IDwmbWVkaWFfYmxrX2N0cmwgSU1YOE1QX01FRElBQkxLX1BEX01J UElfQ1NJMl8xPjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0dXMg PSAiZGlzYWJsZWQiOwo+ID4gPiArCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcG9ydHMgewo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg I2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPiA+ID4gKwo+ID4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcG9ydEAwIHsKPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDA+Owo+ID4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPiA+ID4gKwo+ID4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcG9ydEAxIHsKPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDE+Owo+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB9Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICB9 Owo+ID4gPiArCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIG1pcGlfY3NpXzE6IGNzaUAz MmU1MDAwMCB7Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJs ZSA9ICJmc2wsaW14OG1wLW1pcGktY3NpMiIsICJmc2wsaW14OG1tLW1pcGktY3NpMiI7Cj4gPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4MzJlNTAwMDAgMHgxMDAw MD47Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50ZXJydXB0cyA9IDxH SUNfU1BJIDgwIElSUV9UWVBFX0xFVkVMX0hJR0g+Owo+ID4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNsb2NrLWZyZXF1ZW5jeSA9IDwyNjYwMDAwMDA+Owo+ID4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmY2xrIElNWDhNUF9DTEtfTUVESUFf QVBCX1JPT1Q+LAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IDwmY2xrIElNWDhNUF9DTEtfTUVESUFfQ0FNMl9QSVhfUk9PVD4sCj4gPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPCZjbGsgSU1YOE1QX0NMS19NRURJQV9NSVBJ X1BIWTFfUkVGX1JPT1Q+LAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDwmY2xrIElNWDhNUF9DTEtfTUVESUFfQVhJX1JPT1Q+Owo+ID4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNsb2NrLW5hbWVzID0gInBjbGsiLCAid3JhcCIsICJwaHki LCAiYXhpIjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhc3NpZ25lZC1j bG9ja3MgPSA8JmNsayBJTVg4TVBfQ0xLX01FRElBX0NBTTJfUElYPjsKPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBhc3NpZ25lZC1jbG9jay1wYXJlbnRzID0gPCZjbGsgSU1Y OE1QX1NZU19QTEwyXzEwMDBNPjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBhc3NpZ25lZC1jbG9jay1yYXRlcyA9IDwyNjYwMDAwMDA+Owo+ID4gCj4gPiAyNjZNSHogaXMg Y29ycmVjdCBmb3IgZHVhbCBjYW1lcmEsIGJ1dCBpbiBzaW5nbGUgY2FtZXJhLCB0aGUgc2Vjb25k Cj4gPiBDU0kgaXMgY2FwYWJsZSBvZiAyNzdNSHouCj4gPiAKPiA+IEF0IGEgbWluaW11bSwgSSdk IGxpa2UgdG8gZml4IHRoZSBvdmVyZHJpdmUgZnJlcXVlbmN5IHRvIG5vbWluYWwsIGJ1dAo+ID4g c2luY2Ugd2UncmUgcGx1bWJpbmcgaW4gYm90aCBjYW1lcmFzLCBJIHdvbmRlciBpZiBpdCB3b3Vs ZCBiZSBiZXR0ZXIKPiA+IHRvIHJ1biBib3RoIGF0IDI2Nk1IeiB3aXRoIGEgbm90ZSBvbiBDU0kw IHRoYXQgc3RhdGVzIGl0IGNvdWxkIHJ1biBhdAo+ID4gNDAwIG9yIDUwMCBpZiB0aGUgc2Vjb25k IENTSSBpcyBkaXNhYmxlZCBhbmQgYSBub3RlIG9uIHRoZSBzZWNvbmQgQ1NJCj4gPiB0aGF0IGl0 IGNvdWxkIHJ1biBhdCAyNzcgd2hlbiB0aGUgZmlyc3Qgb25lIGlzIGRpc2FibGVkPyBXaGF0IGFy ZSB5b3VyCj4gPiB0aG91Z2h0cz8KPiAKPiBNeSB0aG91Z2h0cyBpcyB0aGF0IHRoaXMgYWxsIHNo b3VsZCBiZSBzZWxlY3RlZCBhdCBydW50aW1lLCBiYXNlZCBvbiBob3cKPiBtYW55IGNhbWVyYXMg YXJlIHVzZWQuIFRoYXQgd29uJ3QgYmUgdHJpdmlhbCB0byBkbyB0aG91Z2ggOi1TIEtpZXJhbiwK PiB5b3UndmUgYmVlbiB3b3JraW5nIHdpdGggdHdvIGNhbWVyYXMsIGFueSBvcGluaW9uID8KCldl bGwgSSd2ZSBiZWVuIHNlZWluZyBpc3N1ZXMgbGlrZSBkcm9wcGVkIHBhY2tldHMgYW5kIHZhcmlv dXMgaXNzdWVzIG9uCnRoZSBDU0kyIHJlY2VpdmVyIHRoYXQgY291bGQgYmUgYmVjYXVzZSBvZiBi YWRseSBjb25maWd1cmVkIGNsb2NrcyAuLi4Kc28gdGhlcmUncyBkZWZpbml0ZWx5IHNvbWUgdGhp bmdzIHRvIGNoZWNrIGFuZCB2YWxpZGF0ZSBoZXJlIHN0aWxsLgoKSSBkb24ndCBrbm93IGhvdyB0 aGUgY2xvY2tpbmcgd291bGQgYmUgYWRhcHRlZCBhdCBydW50aW1lIHlldCBlaXRoZXIgLi4uCmJ1 dCBpdCBtaWdodCBiZSBzb21ldGhpbmcgaW50ZXJlc3RpbmcgdG8gbG9vayBhdC4gSXQncyBsaWtl bHkgbW9yZQpkaWZmaWN1bHQgYXMgaXQncyB0d28gc2VwYXJhdGUgbm9kZXMgdGhhdCB3b3VsZCBo YXZlIHRvIGtub3cgYWJvdXQgZWFjaApvdGhlciBhdCBzb21lIGxldmVsLgoKLS0KS2llcmFuCgoK PiAKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwb3dlci1kb21haW5zID0g PCZtZWRpYV9ibGtfY3RybCBJTVg4TVBfTUVESUFCTEtfUERfTUlQSV9DU0kyXzI+Owo+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gPiA+ ICsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwb3J0cyB7Cj4gPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwx PjsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICNzaXplLWNl bGxzID0gPDA+Owo+ID4gPiArCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBwb3J0QDAgewo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICByZWcgPSA8MD47Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB9Owo+ID4gPiArCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBwb3J0QDEgewo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICByZWcgPSA8MT47Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB9Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIH07Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIH07Cj4gPiA+ICsKPiA+ID4gICAg ICAgICAgICAgICAgICAgICAgICAgcGNpZV9waHk6IHBjaWUtcGh5QDMyZjAwMDAwIHsKPiA+ID4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gImZzbCxpbXg4bXAt cGNpZS1waHkiOwo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDww eDMyZjAwMDAwIDB4MTAwMDA+Owo+IAo+IC0tIAo+IFJlZ2FyZHMsCj4gCj4gTGF1cmVudCBQaW5j aGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TZ021HKV" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40D5A131; Wed, 29 Nov 2023 12:14:47 -0800 (PST) Received: from pendragon.ideasonboard.com (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9735B6F0; Wed, 29 Nov 2023 21:14:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701288849; bh=uJx2WyhfAxcEwQ+ee41/z9G2InAvJw4jSMa05qDKaAs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=TZ021HKV3henHtehwczYCqsqTxFs1KZRgdIoYtxe64lWfIZh/UwEa3vOWl/1G2spW yt1cy9gKg0as1rKOs5K869+XC4R3yks5V5eFYbFChameoMDnTeJdPvZznKhFGdixRB rTXms0JuWC3kud3Yr5Am3954wtVSGcxSIShacVnw= Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20231129105536.GE24293@pendragon.ideasonboard.com> References: <20230417055627.16482-1-laurent.pinchart@ideasonboard.com> <20230417055627.16482-2-laurent.pinchart@ideasonboard.com> <20231129105536.GE24293@pendragon.ideasonboard.com> Subject: Re: [PATCH v1 1/2] arm64: dts: imx8mp: Add CSIS DT nodes From: Kieran Bingham Cc: Marco Felsch , Alexander Stein , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, Shawn Guo , Krzysztof Kozlowski , Rob Herring , Jacopo Mondi , Xavier Roumegue To: Adam Ford , Laurent Pinchart Date: Wed, 29 Nov 2023 20:14:42 +0000 Message-ID: <170128888298.3048548.2160913449516998097@ping.linuxembedded.co.uk> User-Agent: alot/0.10 Quoting Laurent Pinchart (2023-11-29 10:55:36) > Hi Adam, >=20 > (CC'ing Kieran) >=20 > On Tue, Nov 28, 2023 at 09:17:51PM -0600, Adam Ford wrote: > > On Mon, Apr 17, 2023 at 1:01=E2=80=AFAM Laurent Pinchart wrote: > > > > > > Add DT nodes for the two CSI-2 receivers of the i.MX8MP. > > > > > > Signed-off-by: Laurent Pinchart > > > --- > >=20 > > Laurent, > >=20 > > Sorry to dig up an old thread, but I have a concern about the clock > > ratings and nominal mode vs overdrive mode. I started investigating > > the different data sheets amongst the various imx8m[mnp] families to > > make the default device trees run at nominal mode while also creating > > a separate dtsi file with settings for overdrive so boards who use it > > can include them without having to duplicate the clock settings for > > everyone who supports overdrive. > >=20 > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 60 +++++++++++++++++++++= ++ > > > 1 file changed, 60 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/b= oot/dts/freescale/imx8mp.dtsi > > > index 2dd60e3252f3..2a374a4c14a2 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > @@ -1239,6 +1239,66 @@ ldb_lvds_ch1: endpoint { > > > }; > > > }; > > > > > > + mipi_csi_0: csi@32e40000 { > > > + compatible =3D "fsl,imx8mp-mipi-csi2"= , "fsl,imx8mm-mipi-csi2"; > > > + reg =3D <0x32e40000 0x10000>; > > > + interrupts =3D ; > > > + clock-frequency =3D <500000000>; > > > + clocks =3D <&clk IMX8MP_CLK_MEDIA_APB= _ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_CAM1_= PIX_ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_MIPI_= PHY1_REF_ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_AXI_R= OOT>; > > > + clock-names =3D "pclk", "wrap", "phy"= , "axi"; > > > + assigned-clocks =3D <&clk IMX8MP_CLK_= MEDIA_CAM1_PIX>; > > > + assigned-clock-parents =3D <&clk IMX8= MP_SYS_PLL2_1000M>; > > > + assigned-clock-rates =3D <500000000>; > >=20 > > According to Rev 2.1 of the Data sheet (IMX8MPCEC), dated July 2023, > > 500MHz is listed as single-camera, overdrive mode. Single-camera, > > nominal mode is 400MHz, but there is more... > > If configured for dual cameras, both CSI can only support up to > > 266MHz, but we have partially configured both albeit without the > > actual camera sensors connected. > >=20 > > > + power-domains =3D <&media_blk_ctrl IM= X8MP_MEDIABLK_PD_MIPI_CSI2_1>; > > > + status =3D "disabled"; > > > + > > > + ports { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + port@0 { > > > + reg =3D <0>; > > > + }; > > > + > > > + port@1 { > > > + reg =3D <1>; > > > + }; > > > + }; > > > + }; > > > + > > > + mipi_csi_1: csi@32e50000 { > > > + compatible =3D "fsl,imx8mp-mipi-csi2"= , "fsl,imx8mm-mipi-csi2"; > > > + reg =3D <0x32e50000 0x10000>; > > > + interrupts =3D ; > > > + clock-frequency =3D <266000000>; > > > + clocks =3D <&clk IMX8MP_CLK_MEDIA_APB= _ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_CAM2_= PIX_ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_MIPI_= PHY1_REF_ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_AXI_R= OOT>; > > > + clock-names =3D "pclk", "wrap", "phy"= , "axi"; > > > + assigned-clocks =3D <&clk IMX8MP_CLK_= MEDIA_CAM2_PIX>; > > > + assigned-clock-parents =3D <&clk IMX8= MP_SYS_PLL2_1000M>; > > > + assigned-clock-rates =3D <266000000>; > >=20 > > 266MHz is correct for dual camera, but in single camera, the second > > CSI is capable of 277MHz. > >=20 > > At a minimum, I'd like to fix the overdrive frequency to nominal, but > > since we're plumbing in both cameras, I wonder if it would be better > > to run both at 266MHz with a note on CSI0 that states it could run at > > 400 or 500 if the second CSI is disabled and a note on the second CSI > > that it could run at 277 when the first one is disabled? What are your > > thoughts? >=20 > My thoughts is that this all should be selected at runtime, based on how > many cameras are used. That won't be trivial to do though :-S Kieran, > you've been working with two cameras, any opinion ? Well I've been seeing issues like dropped packets and various issues on the CSI2 receiver that could be because of badly configured clocks ... so there's definitely some things to check and validate here still. I don't know how the clocking would be adapted at runtime yet either ... but it might be something interesting to look at. It's likely more difficult as it's two separate nodes that would have to know about each other at some level. -- Kieran >=20 > > > + power-domains =3D <&media_blk_ctrl IM= X8MP_MEDIABLK_PD_MIPI_CSI2_2>; > > > + status =3D "disabled"; > > > + > > > + ports { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + port@0 { > > > + reg =3D <0>; > > > + }; > > > + > > > + port@1 { > > > + reg =3D <1>; > > > + }; > > > + }; > > > + }; > > > + > > > pcie_phy: pcie-phy@32f00000 { > > > compatible =3D "fsl,imx8mp-pcie-phy"; > > > reg =3D <0x32f00000 0x10000>; >=20 > --=20 > Regards, >=20 > Laurent Pinchart