From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 940FFC4167B for ; Tue, 12 Dec 2023 10:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346206AbjLLKkU (ORCPT ); Tue, 12 Dec 2023 05:40:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjLLKkS (ORCPT ); Tue, 12 Dec 2023 05:40:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C3D99F for ; Tue, 12 Dec 2023 02:40:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id 2C390C433C9; Tue, 12 Dec 2023 10:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702377624; bh=bNZFXT6uE4NzbeIp42aj++88Ef7ZPb0Co0gmFlN7Hz8=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=YeUfoA7RbtZqZNIm0pyXM/cz0+LtFHXinS+bxpAoD1UAmAxBm5wJ6P1fon3FKq1an fRKWKXzGy/l3AezkYKC0HmAwXAQpxZDxsgYCHPDtVjSvfmuq6PL+vVX88NroEy3uHl HMUHk8m8DI0jyaRHJd2vkhiOk5+LFc0/KkQjGIkhaxDiEBQP3DYguF0kK/INn184EB 84guqI2a0BXGdfR64grRIcck29y5zdt38zYHEv2S3J6iU772+Z35gcK9TUUh+C/sMS og2oeNZ/HAab9QuAjGVEN6O/AMg+Xg9FtIrXdNdQeCs8ulkmIiIoUVzlFOEG+12sQ+ WJaXnVoF8R3SQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 146E7DFC907; Tue, 12 Dec 2023 10:40:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v1 1/1] net: dl2k: Use proper conversion of dev_addr before IO to device From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170237762408.11960.6180714999579283849.git-patchwork-notify@kernel.org> Date: Tue, 12 Dec 2023 10:40:24 +0000 References: <20231208153327.3306798-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20231208153327.3306798-1-andriy.shevchenko@linux.intel.com> To: Andy Shevchenko Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lkp@intel.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni : On Fri, 8 Dec 2023 17:33:27 +0200 you wrote: > The driver is using iowriteXX()/ioreadXX() APIs which are LE IO > accessors simplified as > > 1. Convert given value _from_ CPU _to_ LE > 2. Write it to the device as is > > The dev_addr is a byte stream, but because the driver uses 16-bit > IO accessors, it wants to perform double conversion on BE CPUs, > but it took it wrong, as it effectivelly does two times _from_ CPU > _to_ LE. What it has to do is to consider dev_addr as an array of > LE16 and hence do _from_ LE _to_ CPU conversion, followed by implied > _from_ CPU _to_ LE in the iowrite16(). > > [...] Here is the summary with links: - [net-next,v1,1/1] net: dl2k: Use proper conversion of dev_addr before IO to device https://git.kernel.org/netdev/net-next/c/68cbdb150d55 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html