From: patchwork-bot+netdevbpf@kernel.org
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzkaller@googlegroups.com, f6bvp@free.fr
Subject: Re: [PATCH net] net/rose: fix races in rose_kill_by_device()
Date: Fri, 15 Dec 2023 12:10:24 +0000 [thread overview]
Message-ID: <170264222426.21512.10024922314954258007.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20231214152747.1700980-1-edumazet@google.com>
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 14 Dec 2023 15:27:47 +0000 you wrote:
> syzbot found an interesting netdev refcounting issue in
> net/rose/af_rose.c, thanks to CONFIG_NET_DEV_REFCNT_TRACKER=y [1]
>
> Problem is that rose_kill_by_device() can change rose->device
> while other threads do not expect the pointer to be changed.
>
> We have to first collect sockets in a temporary array,
> then perform the changes while holding the socket
> lock and rose_list_lock spinlock (in this order)
>
> [...]
Here is the summary with links:
- [net] net/rose: fix races in rose_kill_by_device()
https://git.kernel.org/netdev/net/c/64b8bc7d5f14
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-12-15 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 15:27 [PATCH net] net/rose: fix races in rose_kill_by_device() Eric Dumazet
2023-12-15 12:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170264222426.21512.10024922314954258007.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=f6bvp@free.fr \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.