All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] eal: remove call to unlock
Date: Wed, 25 Apr 2018 12:32:37 +0200	[thread overview]
Message-ID: <1703557.Am3HRJYA0H@xps> (raw)
In-Reply-To: <9061a11d7dbba7452207c0943b05796f15a0af1d.1524650784.git.anatoly.burakov@intel.com>

25/04/2018 12:08, Anatoly Burakov:
> Coverity was complaining about not checking result of call to
> fcntl() for unlocking the file. Disregarding the fact that error
> value returned from fcntl() unlock call is highly unlikely in the
> first place, we are subsequently calling close() on that same fd,
> which will drop the lock, which makes call to fcntl() unnecessary.
> 
> Fix this by removing a call to fcntl() altogether.
> 
> Coverity issue: 272607
> 
> Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
> Cc: anatoly.burakov@intel.com
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks

      reply	other threads:[~2018-04-25 10:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 15:42 [PATCH 0/2] Coverity fixes for EAL Anatoly Burakov
2018-04-17 15:42 ` [PATCH 1/2] eal: fix potential negative return Anatoly Burakov
2018-04-25  5:55   ` Tan, Jianfeng
2018-04-17 15:42 ` [PATCH 2/2] eal: fix not checking unlock result Anatoly Burakov
2018-04-25  7:09   ` Tan, Jianfeng
2018-04-25  8:53     ` Burakov, Anatoly
2018-04-25 10:08 ` [PATCH v2] Coverity fixes for EAL Anatoly Burakov
2018-04-25 10:08   ` [PATCH v2] eal: remove call to unlock Anatoly Burakov
2018-04-25 10:32     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1703557.Am3HRJYA0H@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.