From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH] m5mols: Replace missing header
Date: Mon, 26 May 2014 11:29:08 +0200 [thread overview]
Message-ID: <1704388.1gDR1zZHE6@avalon> (raw)
In-Reply-To: <5383038C.2060909@samsung.com>
Hi Sylwester,
On Monday 26 May 2014 11:04:12 Sylwester Nawrocki wrote:
> On 25/05/14 21:54, Laurent Pinchart wrote:
> > The include/media/s5p_fimc.h header has been removed in commit
> > 49b2f4c56fbf70ca693d6df1c491f0566d516aea ("exynos4-is: Remove support
> > for non-dt platforms"). This broke compilation of the m5mols driver.
> >
> > Include the include/media/exynos-fimc.h header instead, which contains
> > the S5P_FIMC_TX_END_NOTIFY definition required by the driver.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Thanks for the fix.
You're welcome. I just happened to run across the problem while compiling my
tree, it didn't take long to fix it :-)
> I though about adding to this patch:
>
> Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> But it seems the patch is already in Mauro's tree.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2014-05-26 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 19:54 [PATCH] m5mols: Replace missing header Laurent Pinchart
2014-05-26 9:04 ` Sylwester Nawrocki
2014-05-26 9:29 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1704388.1gDR1zZHE6@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.