From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH] drm/i915: Make sample_c messages go faster on Haswell. Date: Mon, 05 Jan 2015 13:39:36 -0800 Message-ID: <1706304.meRp8Voxv8@vakarian> References: <1420071780-1075-1-git-send-email-kenneth@whitecape.org> <20150105131915.GW2711@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1595521596==" Return-path: Received: from smtp137.dfw.emailsrvr.com (smtp137.dfw.emailsrvr.com [67.192.241.137]) by gabe.freedesktop.org (Postfix) with ESMTP id EE5BA6E2B2 for ; Mon, 5 Jan 2015 13:39:38 -0800 (PST) In-Reply-To: <20150105131915.GW2711@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, "libva@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org --===============1595521596== Content-Type: multipart/signed; boundary="nextPart1446089.zR2bAlop3X"; micalg="pgp-sha256"; protocol="application/pgp-signature" --nextPart1446089.zR2bAlop3X Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" On Monday, January 05, 2015 02:19:15 PM Daniel Vetter wrote: > On Wed, Dec 31, 2014 at 04:23:00PM -0800, Kenneth Graunke wrote: > > Haswell significantly improved the performance of sampler_c message= s, > > but the optimization appears to be off by default. Later platforms= > > remove this bit, and apparently always enable the optimization. > >=20 > > Improves performance in "Counter Strike: Global Offensive" by 18% > > at default settings on Iris Pro. > >=20 > > This may break sampling of paletted formats (P8/A8P8/P8A8). It's > > unclear whether it affects sampling of paletted formats in general,= > > or just the sample_c message (which is never used). > >=20 > > While libva does have support for using paletted formats (primarily= > > for OSDs), that support appears to have been broken for at least a > > year, so I couldn't observe a regression from this. > >=20 > > Signed-off-by: Kenneth Graunke > > --- > > drivers/gpu/drm/i915/i915_reg.h | 1 + > > drivers/gpu/drm/i915/intel_pm.c | 4 ++++ > > 2 files changed, 5 insertions(+) > >=20 > > Resubmitting the patch to unconditionally enable this. I tried to = get > > libva-intel to use paletted formats, and observe a regression...but= the > > only thing I found that used it was mplayer's OSD (on screen displa= y). > > Even without my patch, the colors were totally wrong with that, and= it's > > according to a few distro wikis, that's been the case for over a ye= ar. > >=20 > > If libva's code for paletted formats /is/ broken, they could always= add > > code to disable this bit using the command validator when fixing it= . > >=20 > > Could we try merging this, and back it out if someone reports a > > regression? I haven't observed any problems. It's also been quite= > > stable. >=20 > Yeah makes sense. When resending please incorporated review feedback > (Ville dug out the wa name), I've done that. And I've pasted the > additional detail about the libva saga, just for reference (since no = one > will remember that it's mplayer's OSD which uses this 2 months down t= he > road). >=20 > Also please cc libva mailing lists next time around as an fyi. Done t= hat > too. >=20 > Queued for -next, thanks for the patch. > -Daniel Oh, sorry, I missed that in the review. Thanks, Daniel! =2D-Ken --nextPart1446089.zR2bAlop3X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJUqwSYAAoJEFtb2gcdScw4ubAP/3oMV9YV1qEcAZq1qsKyMIUV Dh19rldmfG7trxpyEZPUEVjFoDvKpMLJCKJE7iP4Cv+HkpWNE2phS7TDp4Iovxxj 1nazDjAuLVH4q3+6kPCjwE0eQfZPV6Il0VfqC1tcxSs0WVIAV3tspQ++9vG94186 CS/knjy+b3lnTcfWuR/bLrUlpi90fNa+k5ZP/o5xnmIAP57WBO9g7FS4NvgP+Tj2 zTMqkdgIKzlmASMuDNXmlA2k2eauv631bU0tcRmuWAvKu4Eqw+SJGURSOpEYMAyt v4eS6KzXQ4rUa1ZCbTOMb2mjSGjRAQWx8Co+1nEeYEh8h4RxxOj2n7i08CkqZkrS 3zGLHxkfYRFYT90sSG/vUqGZ9zOUW4yS7dNgjHtRlD6AsEw1RkERqsU1r/F9Psrf tLJDYb13oMiGht21XNWFlWfmIADJbMGC6mP1OBODGqgmVoBrSsbU99dU7Pwjk2oO 0cgfOrd51AhvrjeVH4+nSVcZGbt1HtU83uNs8jzicmO+jZ+8W50HsU8mMci3VTLA FwGndKyURGM6IGePpTdIu4ZxQN3CXcaQqNns1JQsLTc9lisXjOUcmcr24MYGFua5 kG7pXZohHyOF0i3PLykC/MUbA1vvXHkAC7ZLNEC0t9Z5nIy0MnIJomv3oc4qJIhc y8XbFBezc6NPlel6IHe/ =CHT3 -----END PGP SIGNATURE----- --nextPart1446089.zR2bAlop3X-- --===============1595521596== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1595521596==--