All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	martin.lau@kernel.org, kernel-team@meta.com
Subject: Re: [PATCH bpf-next] selftests/bpf: mark dynptr kfuncs __weak to make them optional on old kernels
Date: Tue, 06 Feb 2024 04:20:26 +0000	[thread overview]
Message-ID: <170719322647.4467.7037327786814411698.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240206004008.1541513-1-andrii@kernel.org>

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Mon,  5 Feb 2024 16:40:08 -0800 you wrote:
> Mark dynptr kfuncs as __weak to allow
> verifier_global_subprogs/arg_ctx_{perf,kprobe,raw_tp} subtests to be
> loadable on old kernels. Because bpf_dynptr_from_xdp() kfunc is used
> from arg_tag_dynptr BPF program in progs/verifier_global_subprogs.c
> *and* is not marked as __weak, loading any subtest from
> verifier_global_subprogs fails on old kernels that don't have
> bpf_dynptr_from_xdp() kfunc defined. Even if arg_tag_dynptr program
> itself is not loaded, libbpf bails out on non-weak reference to
> bpf_dynptr_from_xdp (that can't be resolved), which shared across all
> programs in progs/verifier_global_subprogs.c.
> 
> [...]

Here is the summary with links:
  - [bpf-next] selftests/bpf: mark dynptr kfuncs __weak to make them optional on old kernels
    https://git.kernel.org/bpf/bpf-next/c/c7dcb6c9aa85

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      reply	other threads:[~2024-02-06  4:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06  0:40 [PATCH bpf-next] selftests/bpf: mark dynptr kfuncs __weak to make them optional on old kernels Andrii Nakryiko
2024-02-06  4:20 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170719322647.4467.7037327786814411698.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@meta.com \
    --cc=martin.lau@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.