From: Marcel Hellwig <barebox+mailing@cookiesoft.de>
To: Sascha Hauer <sha@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: Heartbeat LED during init script
Date: Thu, 18 Feb 2021 09:00:42 +0100 (CET) [thread overview]
Message-ID: <1708069310.14913.1613635242547@office.mailbox.org> (raw)
In-Reply-To: <20210217131702.GD19583@pengutronix.de>
Hey Sasha,
I have a slight problem here:
This is what I think:
Because the memtest gets called in the init routine, the `ctrl` is completly ignored, at least I can't interrupt it nor the LED blinks.
But if I insert `poller_call`, the led blinks, but the memtest is painfully slow (like 10x slower at least).
I don't think that this will work for me, but I have to accept, that the LED doesn't blink while doing a memtest.
But an interruptable memtest would be nice at least for the user, so my patch I sent yesterday still remains ;)
Greetings,
Marcel
> Sascha Hauer <sha@pengutronix.de> hat am 17.02.2021 14:17 geschrieben:
>
>
> On Wed, Feb 17, 2021 at 01:44:59PM +0100, barebox+mailing@cookiesoft.de wrote:
> > Hey Sasha,
> >
> > thanks for the answer.
> >
> > > barebox doesn't support interrupts. LED blinking is done in pollers
> >
> > That explains the obversation.
> >
> > > add a ctrlc() call to your memtester code inside some loop.
> > > That will cause the poller to run.
> >
> > I'm not entirely sure, if I understand you correctly or you didn't understand me.
> >
> > I use the memtest command[0] from barebox so there is nothing custom written or any loop that I can control.
>
> Ok, somehow I thought you added some memtest code yourself. I was
> mistaken.
>
> > However, if I understand you correctly one could add the `ctrlc`
> > command in all of these[1] three loops inside the
> > `mem_test_moving_inversions` function. Is that correct?
>
> Yes, correct.
>
> > Or is there an
> > other way to not listen on ctrl+c but let the poller itself run?
>
> You could add poller_call() directly. The idea of adding ctrlc() is just
> that this way you could also make the memtest interruptible for the
> user.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-02-18 8:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 12:22 Heartbeat LED during init script barebox+mailing
2021-02-17 12:35 ` Sascha Hauer
2021-02-17 12:44 ` barebox+mailing
2021-02-17 13:17 ` Sascha Hauer
2021-02-18 8:00 ` Marcel Hellwig [this message]
2021-02-18 8:34 ` Sascha Hauer
2021-02-18 9:01 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1708069310.14913.1613635242547@office.mailbox.org \
--to=barebox+mailing@cookiesoft.de \
--cc=barebox@lists.infradead.org \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.