From: patchwork-bot+netdevbpf@kernel.org
To: Christoph Paasch <cpaasch@apple.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org, roopa@nvidia.com,
cmtaylor@apple.com
Subject: Re: [PATCH net-next] mpls: Do not orphan the skb
Date: Fri, 08 Mar 2024 05:00:37 +0000 [thread overview]
Message-ID: <170987403772.8362.3274190846184456765.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240306181117.77419-1-cpaasch@apple.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 06 Mar 2024 10:11:17 -0800 you wrote:
> We observed that TCP-pacing was falling back to the TCP-layer pacing
> instead of utilizing sch_fq for the pacing. This causes significant
> CPU-usage due to the hrtimer running on a per-TCP-connection basis.
>
> The issue is that mpls_xmit() calls skb_orphan() and thus sets
> skb->sk to NULL. Which implies that many of the goodies of TCP won't
> work. Pacing falls back to TCP-layer pacing. TCP Small Queues does not
> work, ...
>
> [...]
Here is the summary with links:
- [net-next] mpls: Do not orphan the skb
https://git.kernel.org/netdev/net-next/c/8edbd3960150
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-03-08 5:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 18:11 [PATCH net-next] mpls: Do not orphan the skb Christoph Paasch
2024-03-06 18:40 ` Eric Dumazet
2024-03-08 5:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170987403772.8362.3274190846184456765.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=cmtaylor@apple.com \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.