From: Krzysztof Kozlowski <krzk@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH 1/2] regulator: s2mps11: drop redundant sanity checks in s2mpg10_of_parse_cb()
Date: Mon, 9 Feb 2026 17:09:55 +0100 [thread overview]
Message-ID: <170a820d-b987-4fd7-acca-ac88bab9e243@kernel.org> (raw)
In-Reply-To: <20260209-s2mpg1x-regulators-fixes-v1-1-ead348e64e14@linaro.org>
On 09/02/2026 16:07, André Draszik wrote:
> The sanity checks being removed in this commit are useless as earlier
> code checks for out-of-bounds conditions already. They also are
> incorrect (as they're off-by-one).
>
> Simply remove this incorrect code.
>
> No functional change.
If they are incorrect then how it could be "no functional change"? To me
original code looks buggy and this is a fix. Fix must have functional
change...
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/all/aYmsu8qREppwBESH@stanley.mountain/
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-09 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 15:07 [PATCH 0/2] regulator: s2mps11: two small bug fixes (s2mpg1x) André Draszik
2026-02-09 15:07 ` [PATCH 1/2] regulator: s2mps11: drop redundant sanity checks in s2mpg10_of_parse_cb() André Draszik
2026-02-09 16:09 ` Krzysztof Kozlowski [this message]
2026-02-10 5:59 ` André Draszik
2026-02-10 7:28 ` Krzysztof Kozlowski
2026-02-10 9:37 ` André Draszik
2026-02-10 10:51 ` Krzysztof Kozlowski
2026-02-10 11:35 ` André Draszik
2026-02-10 11:39 ` Krzysztof Kozlowski
2026-02-09 15:07 ` [PATCH 2/2] regulator: s2mps11: fix pctrlsel macro usage " André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170a820d-b987-4fd7-acca-ac88bab9e243@kernel.org \
--to=krzk@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.