From: David Howells <dhowells@redhat.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: dhowells@redhat.com, Matt Mackall <mpm@selenic.com>,
Nick Piggin <npiggin@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: unify shmem and tiny-shmem
Date: Thu, 02 Oct 2008 23:23:40 +0100 [thread overview]
Message-ID: <1710.1222986220@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0810011817060.19654@blonde.site>
Hugh Dickins <hugh@veritas.com> wrote:
> That's much nicer than I'd been imagining, thanks Matt: I've no qualms
> about the few #ifdefs you're adding to mm/shmem.c, it does seem an
> outright improvement that you're bringing them together.
It's not an outright improvement. shmem.o is still larger than tiny-shmem.o,
albeit not a lot; however, some embedded people really do count the bytes.
> This ifndef is the ugliest part of it: and looking into it, guess
> what, shmem_get_unmapped_area() hasn't been used since 2.6.20 -
> that's right, isn't it, David?
Ummm... It seems to be. I think it used to be used by SYSV SHM. Certainly
deleting that function causes no link problems.
David
next prev parent reply other threads:[~2008-10-02 22:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 23:49 [PATCH] mm: unify shmem and tiny-shmem Matt Mackall
2008-10-01 15:00 ` David Howells
2008-10-01 18:39 ` Hugh Dickins
2008-10-02 5:38 ` Nick Piggin
2008-10-02 18:57 ` Matt Mackall
2008-10-02 22:23 ` David Howells [this message]
2008-10-02 22:44 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1710.1222986220@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.