All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
To: Johan Hovold <johan@kernel.org>
Cc: Alex Henrie <alexhenrie24@gmail.com>,
	linux-parport@lists.infradead.org, linux-usb@vger.kernel.org,
	sudipm.mukherjee@gmail.com, hkzlabnet@gmail.com,
	 reboots@g-cipher.net, mike@trausch.us
Subject: Re: [PATCH 1/7] docs: driver-api: parport-lowlevel: clarify purpose of PARPORT_MODE_PCSPP
Date: Tue, 12 Mar 2024 08:24:09 -0700	[thread overview]
Message-ID: <1710257049.14565.6.camel@chimera> (raw)
In-Reply-To: <ZfAGdjPgNh2GrVXt@hovoldconsulting.com>

That link is to a question that the submitter asked, and nobody
responded to it. It seems that this patch stems from an incomplete
reading of the kernel documentation. Those docs say:

> SPP (Standard Parallel Port) functions modify so-called SPP registers:
> data, status, and control. The hardware may not actually have
> registers exactly like that, but the PC does and this interface is
> modelled after common PC implementations. Other low-level drivers may
> be able to emulate most of the functionality.

So, the PARPORT_MODE_PCSPP flag denotes the availability of the SPP port
functions, not any fields in a struct.

On Tue, 2024-03-12 at 08:38 +0100, Johan Hovold wrote:
> On Mon, Mar 11, 2024 at 11:50:26PM -0600, Alex Henrie wrote:
> 
> Please write a proper commit message here explaining why this patch is
> needed. You can keep the link if it's relevant, but you still need to
> make the patch self-contained.
> 
> > Link: http://lists.infradead.org/pipermail/linux-parport/2024-February/001237.html
> > Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> 
> Johan


  reply	other threads:[~2024-03-12 15:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12  5:50 [PATCH 1/7] docs: driver-api: parport-lowlevel: clarify purpose of PARPORT_MODE_PCSPP Alex Henrie
2024-03-12  5:50 ` [PATCH 2/7] usb: serial: mos7720: don't advertise PARPORT_MODE_PCSPP Alex Henrie
2024-03-12  7:39   ` Johan Hovold
2024-03-12  9:53     ` Sudip Mukherjee
2024-03-12 15:27       ` Daniel Gimpelevich
2024-03-13  1:30     ` Alex Henrie
2024-03-26  9:10   ` Greg KH
2024-03-12  5:50 ` [PATCH 3/7] usb: misc: uss720: " Alex Henrie
2024-03-12  5:50 ` [PATCH 4/7] usb: misc: uss720: point pp->dev to usbdev->dev Alex Henrie
2024-03-12  7:40   ` Johan Hovold
2024-03-13  1:30     ` Alex Henrie
2024-03-13  8:24       ` Johan Hovold
2024-03-26 15:07   ` [PATCH v2 0/4] usb: misc: uss720: improve support for Belkin F5U002 devices Alex Henrie
2024-03-26 15:07     ` [PATCH v2 1/4] usb: misc: uss720: point pp->dev to usbdev->dev Alex Henrie
2024-03-26 20:14       ` Sudip Mukherjee
2024-03-26 15:07     ` [PATCH v2 2/4] usb: misc: uss720: document the names of the compatible devices Alex Henrie
2024-03-26 15:07     ` [PATCH v2 3/4] usb: misc: uss720: add support for another variant of the Belkin F5U002 Alex Henrie
2024-03-26 15:07     ` [PATCH v2 4/4] usb: misc: uss720: check for incompatible versions " Alex Henrie
2024-03-12  5:50 ` [PATCH 5/7] usb: misc: uss720: document the names of the compatible devices Alex Henrie
2024-03-12 16:00   ` Daniel Gimpelevich
2024-03-12  5:50 ` [PATCH 6/7] usb: misc: uss720: add support for another variant of the Belkin F5U002 Alex Henrie
2024-03-12 15:31   ` Daniel Gimpelevich
2024-03-13  1:22     ` Alex Henrie
2024-03-12  5:50 ` [PATCH 7/7] usb: misc: uss720: check for incompatible versions " Alex Henrie
2024-03-12  7:38 ` [PATCH 1/7] docs: driver-api: parport-lowlevel: clarify purpose of PARPORT_MODE_PCSPP Johan Hovold
2024-03-12 15:24   ` Daniel Gimpelevich [this message]
2024-03-13  1:18     ` Alex Henrie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1710257049.14565.6.camel@chimera \
    --to=daniel@gimpelevich.san-francisco.ca.us \
    --cc=alexhenrie24@gmail.com \
    --cc=hkzlabnet@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-parport@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mike@trausch.us \
    --cc=reboots@g-cipher.net \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.