From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 183F7C54E58 for ; Wed, 13 Mar 2024 08:21:18 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=d82jEuaD; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Tvk4D4wn7z3vXC for ; Wed, 13 Mar 2024 19:21:16 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=d82jEuaD; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=patchwork-bot+netdevbpf@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Tvk3Q0rC8z3bXk for ; Wed, 13 Mar 2024 19:20:34 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 30A04CE16AA; Wed, 13 Mar 2024 08:20:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 6729AC43390; Wed, 13 Mar 2024 08:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710318029; bh=WHOuWjV3IDXUssQ4CoKMeiF90k47wssjsrGAJV5cu4U=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=d82jEuaD7bVXGbzKBcPIN9ASyXJ7OV2fy2+f5U1fckbB2EWSLafi2wY0g1ZYn0kQz 7Sz9Wp8GaYZ1B0ItYEbeT6NkNDE/JqR98d1hSK+GguXoS+L7wJ+cL6G1cTa/VjfwdI v+QQrsjQIKtWMT4YRp8YtIgtRgzLoppxFUd6glWG6XTms5nkwCDqfHpXdfXB/NPNg8 6yWUSLnuNgqKL549fu2Ey3pjE93z9uhUIy+kEPj6+k+CbZuj8PlmGaHG3eT2xT+mAF 78OHYsEsT9np91CfAk7NpNR5sRsB3gqfcwXViOTr99HTaVp6RyUE6dCQ5p21N+BNjH 5dh5B9ObKRX3Q== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 4D806D95060; Wed, 13 Mar 2024 08:20:29 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v5 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171031802931.29357.17308276522742025565.git-patchwork-notify@kernel.org> Date: Wed, 13 Mar 2024 08:20:29 +0000 References: <20240311163830.12952-1-sean.anderson@linux.dev> In-Reply-To: <20240311163830.12952-1-sean.anderson@linux.dev> To: Sean Anderson X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: s.trumtrar@pengutronix.de, linux-kernel@vger.kernel.org, madalin.bucur@nxp.com, vladimir.oltean@nxp.com, roy.pledge@nxp.com, claudiu.manoil@nxp.com, leoyang.li@nxp.com, oss@buserror.net, edumazet@google.com, camelia.groza@nxp.com, netdev@vger.kernel.org, kuba@kernel.org, stable@vger.kernel.org, pabeni@redhat.com, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hello: This series was applied to netdev/net.git (main) by David S. Miller : On Mon, 11 Mar 2024 12:38:29 -0400 you wrote: > smp_call_function_single disables IRQs when executing the callback. To > prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere. > This is already done by qman_update_cgr and qman_delete_cgr; fix the > other lockers. > > Fixes: 96f413f47677 ("soc/fsl/qbman: fix issue in qman_delete_cgr_safe()") > CC: stable@vger.kernel.org > Signed-off-by: Sean Anderson > Reviewed-by: Camelia Groza > Tested-by: Vladimir Oltean > > [...] Here is the summary with links: - [net,v5,1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock https://git.kernel.org/netdev/net/c/584c2a9184a3 - [net,v5,2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock https://git.kernel.org/netdev/net/c/fbec4e7fed89 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D20E318EB2; Wed, 13 Mar 2024 08:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710318029; cv=none; b=KqzdDbjf6rnNo4ey76+0FS3QDgYedAXcpNbRAUH6pjvl7daZzU5iP/qaIqxKKiILRwtMMutygCaMMlot5qOcS/9Ry7B0aYqGc3OXxiOcUl7EvjocgQ7sFdR1FYWw57AE5YTfyzpvxs/6/Q7zy8Q+0gUIWXFqsfTR2eA4k0zkIa4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710318029; c=relaxed/simple; bh=WHOuWjV3IDXUssQ4CoKMeiF90k47wssjsrGAJV5cu4U=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=fHiEcN1YWYCUab3eLzolvu/JWCUN5mqrFqACODsCLRINIVs+KifNR7L4lL0RWMwHfIRyFccpqMGsbenYnpR58MYjAJGxfr8H3csFRPFCWLLfxiUl+K/wcIaSeMz0jrSycw54UaHkzAnFdO2dTW/t62Qt5qI4Qw34RjXib0c8Jm0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d82jEuaD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d82jEuaD" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6729AC43390; Wed, 13 Mar 2024 08:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710318029; bh=WHOuWjV3IDXUssQ4CoKMeiF90k47wssjsrGAJV5cu4U=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=d82jEuaD7bVXGbzKBcPIN9ASyXJ7OV2fy2+f5U1fckbB2EWSLafi2wY0g1ZYn0kQz 7Sz9Wp8GaYZ1B0ItYEbeT6NkNDE/JqR98d1hSK+GguXoS+L7wJ+cL6G1cTa/VjfwdI v+QQrsjQIKtWMT4YRp8YtIgtRgzLoppxFUd6glWG6XTms5nkwCDqfHpXdfXB/NPNg8 6yWUSLnuNgqKL549fu2Ey3pjE93z9uhUIy+kEPj6+k+CbZuj8PlmGaHG3eT2xT+mAF 78OHYsEsT9np91CfAk7NpNR5sRsB3gqfcwXViOTr99HTaVp6RyUE6dCQ5p21N+BNjH 5dh5B9ObKRX3Q== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 4D806D95060; Wed, 13 Mar 2024 08:20:29 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v5 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171031802931.29357.17308276522742025565.git-patchwork-notify@kernel.org> Date: Wed, 13 Mar 2024 08:20:29 +0000 References: <20240311163830.12952-1-sean.anderson@linux.dev> In-Reply-To: <20240311163830.12952-1-sean.anderson@linux.dev> To: Sean Anderson Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, vladimir.oltean@nxp.com, christophe.leroy@csgroup.eu, roy.pledge@nxp.com, linuxppc-dev@lists.ozlabs.org, madalin.bucur@nxp.com, s.trumtrar@pengutronix.de, claudiu.manoil@nxp.com, leoyang.li@nxp.com, oss@buserror.net, camelia.groza@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Hello: This series was applied to netdev/net.git (main) by David S. Miller : On Mon, 11 Mar 2024 12:38:29 -0400 you wrote: > smp_call_function_single disables IRQs when executing the callback. To > prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere. > This is already done by qman_update_cgr and qman_delete_cgr; fix the > other lockers. > > Fixes: 96f413f47677 ("soc/fsl/qbman: fix issue in qman_delete_cgr_safe()") > CC: stable@vger.kernel.org > Signed-off-by: Sean Anderson > Reviewed-by: Camelia Groza > Tested-by: Vladimir Oltean > > [...] Here is the summary with links: - [net,v5,1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock https://git.kernel.org/netdev/net/c/584c2a9184a3 - [net,v5,2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock https://git.kernel.org/netdev/net/c/fbec4e7fed89 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13492C54791 for ; Wed, 13 Mar 2024 08:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Date: Message-Id:From:Subject:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vz+jOHTlacxAuojYuhWeBaobEN0SVM5huyk+WtFD0Ac=; b=sMq4tFBweV0zbY bXsWqb7BlNssXrUkXHwz4hIIkkZM+Ihcmt2fM4sXwDjl7QpbtMYBslDbl3Fn//Kmqi20Pk/cnPYLv 1u0Ky35Cl2T5fxt+wN1/vvt/V1N1GgMIxVInepvR5TstX95InK41cemSOzMEKPmy0v1MDZIyYuo6k axMxf4BGAO4BCB1OcVlhlrefQxbKytsZR5OQwXr//fkysvui3Nqmmv5PDlC1DpHo6tl6dQfovxYfe LOGOUe67ucMXeR/Pa0RbvqRdOS5fL5DT7iwmgbyrF9LRHvDTbVDqta+zEpI3Lm49g5dbQsYCi8Hgn jN7EqOJRWcy079ln+/ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkJql-00000009K5b-2UvP; Wed, 13 Mar 2024 08:20:35 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkJqi-00000009K4e-3pMK for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2024 08:20:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 30A04CE16AA; Wed, 13 Mar 2024 08:20:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 6729AC43390; Wed, 13 Mar 2024 08:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710318029; bh=WHOuWjV3IDXUssQ4CoKMeiF90k47wssjsrGAJV5cu4U=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=d82jEuaD7bVXGbzKBcPIN9ASyXJ7OV2fy2+f5U1fckbB2EWSLafi2wY0g1ZYn0kQz 7Sz9Wp8GaYZ1B0ItYEbeT6NkNDE/JqR98d1hSK+GguXoS+L7wJ+cL6G1cTa/VjfwdI v+QQrsjQIKtWMT4YRp8YtIgtRgzLoppxFUd6glWG6XTms5nkwCDqfHpXdfXB/NPNg8 6yWUSLnuNgqKL549fu2Ey3pjE93z9uhUIy+kEPj6+k+CbZuj8PlmGaHG3eT2xT+mAF 78OHYsEsT9np91CfAk7NpNR5sRsB3gqfcwXViOTr99HTaVp6RyUE6dCQ5p21N+BNjH 5dh5B9ObKRX3Q== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 4D806D95060; Wed, 13 Mar 2024 08:20:29 +0000 (UTC) MIME-Version: 1.0 Subject: Re: [PATCH net v5 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171031802931.29357.17308276522742025565.git-patchwork-notify@kernel.org> Date: Wed, 13 Mar 2024 08:20:29 +0000 References: <20240311163830.12952-1-sean.anderson@linux.dev> In-Reply-To: <20240311163830.12952-1-sean.anderson@linux.dev> To: Sean Anderson Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, vladimir.oltean@nxp.com, christophe.leroy@csgroup.eu, roy.pledge@nxp.com, linuxppc-dev@lists.ozlabs.org, madalin.bucur@nxp.com, s.trumtrar@pengutronix.de, claudiu.manoil@nxp.com, leoyang.li@nxp.com, oss@buserror.net, camelia.groza@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240313_012033_157552_2AA8DBE5 X-CRM114-Status: UNSURE ( 8.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello: This series was applied to netdev/net.git (main) by David S. Miller : On Mon, 11 Mar 2024 12:38:29 -0400 you wrote: > smp_call_function_single disables IRQs when executing the callback. To > prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere. > This is already done by qman_update_cgr and qman_delete_cgr; fix the > other lockers. > > Fixes: 96f413f47677 ("soc/fsl/qbman: fix issue in qman_delete_cgr_safe()") > CC: stable@vger.kernel.org > Signed-off-by: Sean Anderson > Reviewed-by: Camelia Groza > Tested-by: Vladimir Oltean > > [...] Here is the summary with links: - [net,v5,1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock https://git.kernel.org/netdev/net/c/584c2a9184a3 - [net,v5,2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock https://git.kernel.org/netdev/net/c/fbec4e7fed89 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel