From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes Date: Wed, 22 Oct 2014 10:45:38 +0200 Message-ID: <1710340.mrZid3JfsP@xps13> References: <1413881168-20239-1-git-send-email-jijiang.liu@intel.com> <2450996.3KDeDxoTz7@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D82548@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Liu, Jijiang" Return-path: In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D82548-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-21 14:14, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > > 2014-10-21 16:46, Jijiang Liu: > > > - uint16_t reserved2; /**< Unused field. Required for padding */ > > > + > > > + /** > > > + * Packet type, which is used to indicate ordinary L2 packet format and > > > + * also tunneled packet format such as IP in IP, IP in GRE, MAC in GRE > > > + * and MAC in UDP. > > > + */ > > > + uint16_t packet_type; > > > > Why not name it "l2_type"? > > In datasheet, this term is called packet type(s). That's exactly the point I want you really understand! This is a field in generic mbuf structure, so your datasheet has no value here. > Personally , I think packet type is more clear what meaning of this field is . ^_^ You cannot add an API field without knowing what will be its generic meaning. Please think about it and describe its scope. Thanks -- Thomas