From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7E77CD1292 for ; Mon, 8 Apr 2024 10:10:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 56AF381EC1; Mon, 8 Apr 2024 10:10:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id aJ0YX6bnXRuP; Mon, 8 Apr 2024 10:10:35 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8D76E81ED2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1712571035; bh=/huYobYq5KCE4csYMJA/WWSJl9IQXHyYAxE17DSw7c8=; h=From:Date:References:In-Reply-To:To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=CbvcEc4KDdUjB55036sbpiyZzbOwZsYmNxfZBqocO3AjY0Heo2WionaHq2S8EQFiL 5UCzWRPMSPuH6liQTjQWaiZOqUZ4/gbIeJbX5wPi3CaI8zkNjJC8eoPYW03FT62MPo Qp/3i0U7iL+MUv6+B7FfaJLEI4rExgmI1hSzx2hqyf/axogd2qL70ta2qr2/i52ltq dy2SWj0NwMwRHsXs6K7LSauOIRdxI6uDhxe52kSxMvKv04JhSo4ITSVs5tAQcdIUnZ QmDDwMW7fUvuHxFRCfEUAe4WX4gsWjACfICk+SoOG3V8asE/KGlAfeBGefabEl32dH K18spHQ4MiRRA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 8D76E81ED2; Mon, 8 Apr 2024 10:10:35 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id DC7911BF3CD for ; Mon, 8 Apr 2024 10:10:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C734E40732 for ; Mon, 8 Apr 2024 10:10:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id oUVPOt5kuPsu for ; Mon, 8 Apr 2024 10:10:32 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=patchwork-bot+netdevbpf@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7CDE840721 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7CDE840721 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7CDE840721 for ; Mon, 8 Apr 2024 10:10:32 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 08099CE0F8F; Mon, 8 Apr 2024 10:10:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 2BE3AC43394; Mon, 8 Apr 2024 10:10:27 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 212C4C54BD9; Mon, 8 Apr 2024 10:10:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171257102713.30740.3149927029161291551.git-patchwork-notify@kernel.org> Date: Mon, 08 Apr 2024 10:10:27 +0000 References: <20240404160302.3585661-1-aleksander.lobakin@intel.com> In-Reply-To: <20240404160302.3585661-1-aleksander.lobakin@intel.com> To: Alexander Lobakin X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712571027; bh=x+XrOol6yWyCizxrCWOJ4+a0py0a9Q0xvIdnby2O6R0=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=qlp4k2VDn9EuhCEJk7K3FBy3HYyssjwc6Q8Z6TIDwXjvRWs8iEtjO8rtbGlclPSSW lyiHMiLP6hYzFvOL0oJ5QKSTNTWmnfH5dKpu+A9oAJcLIxzvVp/KZvMkLT9UvjnK6A ymVtTiu81lybfdx0DhYxq3h9orjun1qP1LgpD9VXlXo8whpqXOrI+54W/CDI0Zdu6y CClsuWCjtzn+dWR+HgM76Kvu1nplipakS2h8Y8Ypj2OUQaQj3lPWvpv1HCi8l/6jhI TG75Zya/QxSLXpW22pdQpxI0f7QVDu4lhouQz4GIL5Pl9q//g/u7plnfHKRaUztIJL 1ebsv50Ml6aBA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=qlp4k2VD Subject: Re: [Intel-wired-lan] [PATCH net-next] ip_tunnel: harden copying IP tunnel params to userspace X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, dsahern@kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, intel-wired-lan@lists.osuosl.org, horms@kernel.org, nex.sw.ncis.osdt.itp.upstreaming@intel.com, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net, dan.carpenter@linaro.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Thu, 4 Apr 2024 18:03:02 +0200 you wrote: > Structures which are about to be copied to userspace shouldn't have > uninitialized fields or paddings. > memset() the whole &ip_tunnel_parm in ip_tunnel_parm_to_user() before > filling it with the kernel data. The compilers will hopefully combine > writes to it. > > Fixes: 117aef12a7b1 ("ip_tunnel: use a separate struct to store tunnel params in the kernel") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/netdev/5f63dd25-de94-4ca3-84e6-14095953db13@moroto.mountain > Signed-off-by: Alexander Lobakin > > [...] Here is the summary with links: - [net-next] ip_tunnel: harden copying IP tunnel params to userspace https://git.kernel.org/netdev/net-next/c/5a66cda52d7d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 754425338D; Mon, 8 Apr 2024 10:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712571027; cv=none; b=U7fWdaoXLNFdDmBG9UuvA13PhIthVc6SQVQ8KCtq6p1ay3rhB66JVNmnsUIYhrMuoGzuFDfNhS7+3MKyJBlY02MNhxato6V+ocf6bWK9W/p1OUMPy0ksHiHY5WDIvj1iTQxnZhD8axehoz2aHGVvn+SKEq9GuKhu1QW6JoTDuZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712571027; c=relaxed/simple; bh=x+XrOol6yWyCizxrCWOJ4+a0py0a9Q0xvIdnby2O6R0=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=Jc3aDZ6MKd4BkiQRvvkZmX44KXTyeveMk/PZ93Gmxd2UAX1IsuT7rC8D5Ges8SgbYSaCQ4Db5SJNdFYhbPSGr688XklmO3k1iv7WSeLt4Z7iCr6g7oZvjPBWc+u/wGffsmQb83wvo6kmFTEGoPgMaxh3RjEnfvhd2N/4A7yc4SE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qlp4k2VD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qlp4k2VD" Received: by smtp.kernel.org (Postfix) with ESMTPS id 2BE3AC43394; Mon, 8 Apr 2024 10:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712571027; bh=x+XrOol6yWyCizxrCWOJ4+a0py0a9Q0xvIdnby2O6R0=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=qlp4k2VDn9EuhCEJk7K3FBy3HYyssjwc6Q8Z6TIDwXjvRWs8iEtjO8rtbGlclPSSW lyiHMiLP6hYzFvOL0oJ5QKSTNTWmnfH5dKpu+A9oAJcLIxzvVp/KZvMkLT9UvjnK6A ymVtTiu81lybfdx0DhYxq3h9orjun1qP1LgpD9VXlXo8whpqXOrI+54W/CDI0Zdu6y CClsuWCjtzn+dWR+HgM76Kvu1nplipakS2h8Y8Ypj2OUQaQj3lPWvpv1HCi8l/6jhI TG75Zya/QxSLXpW22pdQpxI0f7QVDu4lhouQz4GIL5Pl9q//g/u7plnfHKRaUztIJL 1ebsv50Ml6aBA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 212C4C54BD9; Mon, 8 Apr 2024 10:10:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next] ip_tunnel: harden copying IP tunnel params to userspace From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171257102713.30740.3149927029161291551.git-patchwork-notify@kernel.org> Date: Mon, 08 Apr 2024 10:10:27 +0000 References: <20240404160302.3585661-1-aleksander.lobakin@intel.com> In-Reply-To: <20240404160302.3585661-1-aleksander.lobakin@intel.com> To: Alexander Lobakin Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, dan.carpenter@linaro.org, dsahern@kernel.org, horms@kernel.org, nex.sw.ncis.osdt.itp.upstreaming@intel.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Thu, 4 Apr 2024 18:03:02 +0200 you wrote: > Structures which are about to be copied to userspace shouldn't have > uninitialized fields or paddings. > memset() the whole &ip_tunnel_parm in ip_tunnel_parm_to_user() before > filling it with the kernel data. The compilers will hopefully combine > writes to it. > > Fixes: 117aef12a7b1 ("ip_tunnel: use a separate struct to store tunnel params in the kernel") > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/netdev/5f63dd25-de94-4ca3-84e6-14095953db13@moroto.mountain > Signed-off-by: Alexander Lobakin > > [...] Here is the summary with links: - [net-next] ip_tunnel: harden copying IP tunnel params to userspace https://git.kernel.org/netdev/net-next/c/5a66cda52d7d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html