From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 943EC14AD2E; Thu, 25 Apr 2024 15:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714059034; cv=none; b=C05/mk+KhLk8KqwaKLdCVuZ1pW8rVf87ZVNVu22xtWbJ1Lfvt4XEq4yRDloJrIYOEIojaNsFdxHd3an70sref4aFAXX6FDunuGeCcaoaW/y0EMrzmU//XiZH7ouAV8iZ/vrrB0Kxkz5BM2V2SvDBxtyPL+SMUHO0L08DO5+KnlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714059034; c=relaxed/simple; bh=c72zLocSIR3CxXrqJBjeWWnmB7baaCULJUGYE4ucAbE=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=g/Wrx3TeHN7z/omxIMNczbmF/4WESjrcXcxrmYJZqZPjwV9DTeq8YYRuFt3Gd6TxDoMJKdQXockXGT2IV0Tiykv+TEmIva6DQRHR3AqwfVcWWhyq6UxUI1gry/H0JYmpkXWY5rir7HaDVSBVnemJnYzr/jrKE+jdr2m7Iw/70Sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fypgInQV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fypgInQV" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4D065C4AF08; Thu, 25 Apr 2024 15:30:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714059034; bh=c72zLocSIR3CxXrqJBjeWWnmB7baaCULJUGYE4ucAbE=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=fypgInQVBcqty0KxIrsiX/GKCIsHgr+fuUZMKrJzrAU/m3t6SmuNMNuQFymOwAvWU LMibSj3p3H4eYdUBhbimaegfVKffq5MaYAI7zfTYnOHhT6+A5PxrnEt300VeKKwYDk Ycw4Df+gSV4rx0iM7jwtxVLunaWzfclMNMFyYdcB0mmh2B1IwOikYmHIlK8iKUn3Rl jX0kNbM0CDPg0ey05biml++lwRjOIq82/PgtvFKd0UVfYedQNSTekpzlO0Jun5iAkx uV3apFJ67zT/2bMhYiwpxKjijPTJUtkhxQQg8phEqvKPLiaowxvb5IFJQYTYBpReUi kmlD/T1T9QopA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 33CD1CF21C4; Thu, 25 Apr 2024 15:30:34 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_rx_chns() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171405903420.5824.17370077851663422898.git-patchwork-notify@kernel.org> Date: Thu, 25 Apr 2024 15:30:34 +0000 References: <05282415-e7f4-42f3-99f8-32fde8f30936@moroto.mountain> In-Reply-To: <05282415-e7f4-42f3-99f8-32fde8f30936@moroto.mountain> To: Dan Carpenter Cc: rogerq@ti.com, danishanwar@ti.com, rogerq@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch, jan.kiszka@siemens.com, diogo.ivo@siemens.com, robh@kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 23 Apr 2024 19:15:22 +0300 you wrote: > The rx_chn->irq[] array is unsigned int but it should be signed for the > error handling to work. Also if k3_udma_glue_rx_get_irq() returns zero > then we should return -ENXIO instead of success. > > Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver") > Signed-off-by: Dan Carpenter > > [...] Here is the summary with links: - [net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_rx_chns() https://git.kernel.org/netdev/net/c/4dcd0e83ea1d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCE11C4345F for ; Thu, 25 Apr 2024 15:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Date: Message-Id:From:Subject:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3P7PkF/N1rmsrRsmekcX0RvJG6GnDlf9sFri8TtZXvI=; b=GxVXyKUJXy+zxT MyZYu++RyfLOH1oE0qI7kuPk2mi/H1U+wtQ99pdGsWZp2M3piyE/M7hLPDjbD35FzC/SEBLTtQ6rF O6xjyiGpiL7/lDNmyXcPCc7+C5/vcXJpJEmvHzSKrP+xeZqp1qjjyEmviISljrMuK/4d7QYmLMI5u /E3k0aAGvlJpNJ8X4CF5qNChM0Hrj5AkduO0cEHw20OWDoSpnGGBjDs7qgW/KTaQbmJH2vbRkuGIT PB1/u+SpboR0gS/vTBuy6ww5XNHX7JHreMuj5Z3eF8p5s/KjOQEiByz8Zgp6sw7uJgd9zLIZwkN83 t5AiBAXYxLschwiMxirQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s013a-000000099D9-2FDN; Thu, 25 Apr 2024 15:30:42 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s013W-000000099BY-3s4v for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2024 15:30:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7B1FECE1ABC; Thu, 25 Apr 2024 15:30:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 4D065C4AF08; Thu, 25 Apr 2024 15:30:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714059034; bh=c72zLocSIR3CxXrqJBjeWWnmB7baaCULJUGYE4ucAbE=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=fypgInQVBcqty0KxIrsiX/GKCIsHgr+fuUZMKrJzrAU/m3t6SmuNMNuQFymOwAvWU LMibSj3p3H4eYdUBhbimaegfVKffq5MaYAI7zfTYnOHhT6+A5PxrnEt300VeKKwYDk Ycw4Df+gSV4rx0iM7jwtxVLunaWzfclMNMFyYdcB0mmh2B1IwOikYmHIlK8iKUn3Rl jX0kNbM0CDPg0ey05biml++lwRjOIq82/PgtvFKd0UVfYedQNSTekpzlO0Jun5iAkx uV3apFJ67zT/2bMhYiwpxKjijPTJUtkhxQQg8phEqvKPLiaowxvb5IFJQYTYBpReUi kmlD/T1T9QopA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 33CD1CF21C4; Thu, 25 Apr 2024 15:30:34 +0000 (UTC) MIME-Version: 1.0 Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_rx_chns() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171405903420.5824.17370077851663422898.git-patchwork-notify@kernel.org> Date: Thu, 25 Apr 2024 15:30:34 +0000 References: <05282415-e7f4-42f3-99f8-32fde8f30936@moroto.mountain> In-Reply-To: <05282415-e7f4-42f3-99f8-32fde8f30936@moroto.mountain> To: Dan Carpenter Cc: rogerq@ti.com, danishanwar@ti.com, rogerq@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch, jan.kiszka@siemens.com, diogo.ivo@siemens.com, robh@kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_083039_193332_9CAB6875 X-CRM114-Status: UNSURE ( 9.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 23 Apr 2024 19:15:22 +0300 you wrote: > The rx_chn->irq[] array is unsigned int but it should be signed for the > error handling to work. Also if k3_udma_glue_rx_get_irq() returns zero > then we should return -ENXIO instead of success. > > Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver") > Signed-off-by: Dan Carpenter > > [...] Here is the summary with links: - [net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_rx_chns() https://git.kernel.org/netdev/net/c/4dcd0e83ea1d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel