From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Date: Sun, 10 Jan 2016 19:23:40 +0100 Message-ID: <1714176.Nme8cQ9zc4@phil> References: <1452410557-29208-1-git-send-email-zhengxing@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Xing Zheng Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll , Ian Campbell , Kumar Gala , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, keescook-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, leozwang-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, xing.zheng-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: linux-rockchip.vger.kernel.org QW0gU29ubnRhZywgMTAuIEphbnVhciAyMDE2LCAxODozNjoxMiBzY2hyaWViIFhpbmcgWmhlbmc6 Cj4gSGkgSGVpa28sCj4gCj4gPiDlnKggMjAxNuW5tDHmnIgxMOaXpe+8jDE4OjI577yMWGluZyBa aGVuZyA8emhlbmd4aW5nQHJvY2stY2hpcHMuY29tPiDlhpnpgZPvvJoKPiA+IAo+ID4gCj4gPiBI aSBIZWlrbywKPiA+IAo+ID4+IOWcqCAyMDE25bm0MeaciDEw5pel77yMMTc6NTnvvIxIZWlrbyBT dHVlYm5lciA8aGVpa29Ac250ZWNoLmRlPiDlhpnpgZPvvJoKPiA+PiAKPiA+PiBIaSBYaW5nLAo+ ID4+IAo+ID4+IEFtIFNvbm50YWcsIDEwLiBKYW51YXIgMjAxNiwgMTU6MjI6Mzcgc2NocmllYiBY aW5nIFpoZW5nOgo+ID4+PiBCZWNhdXNlIHRoZSBSSzMwMzYgZG9lc24ndCBzdXBwb3J0IEVNQUMs IGFuZCBvbmx5IHN1cHBvcnQgdGhlIFJNSUkKPiA+Pj4gbW9kZQo+ID4+PiBpbiB0aGUgRU1BQyBJ UCwgd2UgcmVmZXIgdG8gdGhlIFRSTSBDUlUgYW5kIHVwZGF0ZSB0aGUgbmV3IGV4dGVybmFsCj4g Pj4+IGNsb2NrIG5hbWUgZm9yIEVNQUMuCj4gPj4+IAo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBYaW5n IFpoZW5nIDx6aGVuZ3hpbmdAcm9jay1jaGlwcy5jb20+Cj4gPj4gCj4gPj4gYXMgSSBzYWlkIGlu IHRoZSBvdGhlciBtYWlsLCBJIGFscmVhZHkgZml4ZWQgdGhlIG9yaWdpbmFsIHBhdGNoIG15c2Vs Zgo+ID4+IDotKSBTbyBJJ20ganVzdCBnb2luZyB0byBkcm9wIHRoaXMgb25lLgo+ID4+IAo+ID4+ IAo+ID4+IEhlaWtvCj4gPj4gCj4gPj4gaHR0cHM6Ly9naXQua2VybmVsLm9yZy9jZ2l0L2xpbnV4 L2tlcm5lbC9naXQvbW1pbmQvbGludXgtcm9ja2NoaXAuZ2l0L2MKPiA+PiBvbW1pdC8/aD12NC41 LWNsay9maXhlcyZpZD04ODgwNzkwNmFmMTA4YTgzODRkNzdhZDljZmI5NDIxZjE2NGVhOTMxPiAK PiA+IEkgYW0gc29ycnkgdG8gbWlzdW5kZXJzdGFuZC4KPiA+IAo+ID4gT0ssIHRoYW5rIHlvdSBm b3IgeW91ciBoZWxwLiAgOikKPiAKPiBZb3VyIHBhdGNoIGlzOgo+IC0gLSAiZXh0X2dtYWMiIC0g ZXh0ZXJuYWwgR01BQyBjbG9jayAtIG9wdGlvbmFsCj4gKyAtICJybWlpX2Nsa2luIiAtIGV4dGVy bmFsIEdNQUMgY2xvY2sgLSBvcHRpb25hbAo+IAo+IEkgdGhpbmsgdGhhdCB0aGVzZSBzaG91bGQg YmUgbGlrZSB0aGlzOgo+IC0gLSAiZXh0X2dtYWMiIC0gZXh0ZXJuYWwgR01BQyBjbG9jayAtIG9w dGlvbmFsCj4gKyAtICJybWlpX2Nsa2luIiAtIGV4dGVybmFsIEVNQUMgY2xvY2sgLSBvcHRpb25h bAoKSSBmaXhlZCB0aGF0IHVwIG5vdywgdGhhbmtzIGZvciBjYXRjaGluZyB0aGlzLgoKaHR0cHM6 Ly9naXQua2VybmVsLm9yZy9jZ2l0L2xpbnV4L2tlcm5lbC9naXQvbW1pbmQvbGludXgtcm9ja2No aXAuZ2l0L2NvbW1pdC8/aD12NC41LWNsay9maXhlcyZpZD0xYzg4OGViMTA1NGEwODYyMGE4ZDJi YzVkZDJkN2NjMjkwODk3MzcxCgoKSGVpa28KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2Nr Y2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Sun, 10 Jan 2016 19:23:40 +0100 Subject: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC In-Reply-To: References: <1452410557-29208-1-git-send-email-zhengxing@rock-chips.com> Message-ID: <1714176.Nme8cQ9zc4@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Sonntag, 10. Januar 2016, 18:36:12 schrieb Xing Zheng: > Hi Heiko, > > > ? 2016?1?10??18:29?Xing Zheng ??? > > > > > > Hi Heiko, > > > >> ? 2016?1?10??17:59?Heiko Stuebner ??? > >> > >> Hi Xing, > >> > >> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng: > >>> Because the RK3036 doesn't support EMAC, and only support the RMII > >>> mode > >>> in the EMAC IP, we refer to the TRM CRU and update the new external > >>> clock name for EMAC. > >>> > >>> Signed-off-by: Xing Zheng > >> > >> as I said in the other mail, I already fixed the original patch myself > >> :-) So I'm just going to drop this one. > >> > >> > >> Heiko > >> > >> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/c > >> ommit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931> > > I am sorry to misunderstand. > > > > OK, thank you for your help. :) > > Your patch is: > - - "ext_gmac" - external GMAC clock - optional > + - "rmii_clkin" - external GMAC clock - optional > > I think that these should be like this: > - - "ext_gmac" - external GMAC clock - optional > + - "rmii_clkin" - external EMAC clock - optional I fixed that up now, thanks for catching this. https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=1c888eb1054a08620a8d2bc5dd2d7cc290897371 Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757286AbcAJSYD (ORCPT ); Sun, 10 Jan 2016 13:24:03 -0500 Received: from gloria.sntech.de ([95.129.55.99]:54299 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756583AbcAJSYA convert rfc822-to-8bit (ORCPT ); Sun, 10 Jan 2016 13:24:00 -0500 From: Heiko Stuebner To: Xing Zheng Cc: linux-rockchip@lists.infradead.org, keescook@google.com, leozwang@google.com, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xing.zheng@rock-chips.com Subject: Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Date: Sun, 10 Jan 2016 19:23:40 +0100 Message-ID: <1714176.Nme8cQ9zc4@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-trunk-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: References: <1452410557-29208-1-git-send-email-zhengxing@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, 10. Januar 2016, 18:36:12 schrieb Xing Zheng: > Hi Heiko, > > > 在 2016年1月10日，18:29，Xing Zheng 写道： > > > > > > Hi Heiko, > > > >> 在 2016年1月10日，17:59，Heiko Stuebner 写道： > >> > >> Hi Xing, > >> > >> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng: > >>> Because the RK3036 doesn't support EMAC, and only support the RMII > >>> mode > >>> in the EMAC IP, we refer to the TRM CRU and update the new external > >>> clock name for EMAC. > >>> > >>> Signed-off-by: Xing Zheng > >> > >> as I said in the other mail, I already fixed the original patch myself > >> :-) So I'm just going to drop this one. > >> > >> > >> Heiko > >> > >> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/c > >> ommit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931> > > I am sorry to misunderstand. > > > > OK, thank you for your help. :) > > Your patch is: > - - "ext_gmac" - external GMAC clock - optional > + - "rmii_clkin" - external GMAC clock - optional > > I think that these should be like this: > - - "ext_gmac" - external GMAC clock - optional > + - "rmii_clkin" - external EMAC clock - optional I fixed that up now, thanks for catching this. https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=1c888eb1054a08620a8d2bc5dd2d7cc290897371 Heiko