From: patchwork-bot+ofono@kernel.org
To: Steve Schrock <steve.schrock@getcruise.com>
Cc: ofono@lists.linux.dev
Subject: Re: [PATCH] qmimodem: Fix error path memory leak in gobi
Date: Tue, 07 May 2024 16:30:30 +0000 [thread overview]
Message-ID: <171509943001.26156.16901924428295697285.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240507153408.681340-1-steve.schrock@getcruise.com>
Hello:
This patch was applied to ofono.git (master)
by Denis Kenzior <denkenz@gmail.com>:
On Tue, 7 May 2024 10:33:58 -0500 you wrote:
> I noticed this leak when I terminated ofonod while gobi was retrying
> discovery on an unresponsive QMUX device.
>
> ==8257== 20 (16 direct, 4 indirect) bytes in 1 blocks are definitely lost in loss record 31 of 154
> ==8257== at 0x4885118: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-arm64-linux.so)
> ==8257== by 0x5A4737: l_malloc (util.c:49)
> ==8257== by 0x4669E3: qmi_param_new (qmi.c:2374)
> ==8257== by 0x466D73: qmi_param_new_uint8 (qmi.c:2449)
> ==8257== by 0x47D717: gobi_disable (gobi.c:482)
> ==8257== by 0x51BAD7: set_powered (modem.c:986)
> ==8257== by 0x51E8FB: __ofono_modem_shutdown (modem.c:2279)
> ==8257== by 0x518233: signal_handler (main.c:85)
> ==8257== by 0x496D14F: ??? (in /usr/lib/aarch64-linux-gnu/libglib-2.0.so.0.7800.0)
> ==8257== by 0x49CDE47: ??? (in /usr/lib/aarch64-linux-gnu/libglib-2.0.so.0.7800.0)
> ==8257== by 0x496DBFF: g_main_loop_run (in /usr/lib/aarch64-linux-gnu/libglib-2.0.so.0.7800.0)
> ==8257== by 0x518A23: main (main.c:314)
>
> [...]
Here is the summary with links:
- qmimodem: Fix error path memory leak in gobi
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=d5d99ff50355
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-05-07 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 15:33 [PATCH] qmimodem: Fix error path memory leak in gobi Steve Schrock
2024-05-07 16:30 ` patchwork-bot+ofono [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171509943001.26156.16901924428295697285.git-patchwork-notify@kernel.org \
--to=patchwork-bot+ofono@kernel.org \
--cc=ofono@lists.linux.dev \
--cc=steve.schrock@getcruise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.