Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

[Paul Mackerras <paulus@samba.org>]

Linas Vepstas writes:

> > One way to clean this up would be to make rpaphp the driver for the
> > EADS bridges (from the pci code's point of view).  
> 
> I guess I don't understand what that means. Are you suggesting moving 
> pSeries_pci.c into the rpaphp code directory?

No, not at all. :)

I'm suggesting that the rpaphp code has a struct pci_driver whose
id_table and probe function are such that it will claim the EADS
bridges.  (It would probably be best to match on vendor=IBM and
class=PCI-PCI bridge and let the probe function figure out which of
the bridges it gets asked about are actually EADS bridges.)

> I would prefer to deprecate the hot-plug based recovery scheme.  This
> is for many reasons, including the fact that some devices that can get
> pci errors are soldered onto the planar, and are not hot-pluggable.

Those devices can still be isolated and reset, can they not?  And they
still have an EADS bridge above them, don't they?  Are there any that
can't be dynamically reassigned from one partition to another?  I.e.,
they may not be physically hotpluggable but they are still virtually
hotpluggable as far as the partition is concerned, IIUC.

Paul.