From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF33AC2D0EC for ; Sat, 11 Apr 2020 03:02:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78952206DA for ; Sat, 11 Apr 2020 03:02:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=coker.com.au header.i=@coker.com.au header.b="LKUCWYKC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbgDKDCS (ORCPT ); Fri, 10 Apr 2020 23:02:18 -0400 Received: from smtp.sws.net.au ([46.4.88.250]:38468 "EHLO smtp.sws.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726657AbgDKDCS (ORCPT ); Fri, 10 Apr 2020 23:02:18 -0400 Received: from liv.localnet (localhost [127.0.0.1]) by smtp.sws.net.au (Postfix) with ESMTP id 25ABEEC7C for ; Sat, 11 Apr 2020 13:02:15 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coker.com.au; s=2008; t=1586574136; bh=WQ1lZDM6Hz28wkaxXVjkQPvbIXK3Rte9hxQcM4dHdkQ=; l=1108; h=From:To:Subject:Date:From; b=LKUCWYKCWp26UekQFHdYsMBN5ZxOGatu6ycq4b/m3aaDKrpNgLnHRY9NCpHdnyqTB RdZrPjdDOE4Yfag3yMfplmaEUsDCyt4L9383gyMLp0rU+rPqH+Oe2Pia/vc6OgKw+7 35rlx1erFCgztj+0Z3dS2qvehSfpN2ajTaZzL41A= From: Russell Coker To: selinux-refpolicy@vger.kernel.org Subject: systemd_generator_t vs systemd_generator_type Date: Sat, 11 Apr 2020 13:02:10 +1000 Message-ID: <1717302.MpC4nazLU5@liv> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org This combination of names is confusing. As a general rule I think we shouldn't have a type name be a substring of an attribute name. Having an attribute name as a substring of a type name is less of an issue but still best avoided. /lib/systemd/system-generators/systemd-bless-boot-generator /lib/systemd/system-generators/systemd-cryptsetup-generator /lib/systemd/system-generators/systemd-debug-generator /lib/systemd/system-generators/systemd-getty-generator /lib/systemd/system-generators/systemd-hibernate-resume-generator /lib/systemd/system-generators/systemd-rc-local-generator /lib/systemd/system-generators/systemd-run-generator /lib/systemd/system-generators/systemd-system-update-generator /lib/systemd/system-generators/systemd-veritysetup-generator /usr/lib/systemd/user-environment-generators/30-systemd-environment-d- generator Above are the generators on my system that run as systemd_generator_t. Would systemd_generator_generic_t/systemd_generator_generic_exec_t be an OK name? -- My Main Blog http://etbe.coker.com.au/ My Documents Blog http://doc.coker.com.au/