From: Kees Cook <kees@kernel.org>
To: thierry.reding@gmail.com, jonathanh@nvidia.com, andy@kernel.org,
akpm@linux-foundation.org,
Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: Kees Cook <kees@kernel.org>,
linux-tegra@vger.kernel.org, linux-hardening@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/util: Swap kmemdup_array() arguments
Date: Thu, 6 Jun 2024 08:55:53 -0700 [thread overview]
Message-ID: <171768935175.54606.14878127902164737048.b4-ty@kernel.org> (raw)
In-Reply-To: <20240606144608.97817-2-jean-philippe@linaro.org>
On Thu, 06 Jun 2024 15:46:09 +0100, Jean-Philippe Brucker wrote:
> GCC 14.1 complains about the argument usage of kmemdup_array():
>
> drivers/soc/tegra/fuse/fuse-tegra.c:130:65: error: 'kmemdup_array' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
> 130 | fuse->lookups = kmemdup_array(fuse->soc->lookups, sizeof(*fuse->lookups),
> | ^
> drivers/soc/tegra/fuse/fuse-tegra.c:130:65: note: earlier argument should specify number of elements, later size of each element
>
> [...]
Applied to for-next/hardening, thanks!
[1/1] mm/util: Swap kmemdup_array() arguments
https://git.kernel.org/kees/c/0ee14725471c
Take care,
--
Kees Cook
next prev parent reply other threads:[~2024-06-06 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 14:46 [PATCH] mm/util: Swap kmemdup_array() arguments Jean-Philippe Brucker
2024-06-06 15:36 ` Andy Shevchenko
2024-06-06 15:55 ` Kees Cook [this message]
2024-06-06 17:35 ` Andy Shevchenko
2024-06-06 17:46 ` Kees Cook
2024-06-06 17:48 ` Andy Shevchenko
2024-06-06 18:10 ` Kees Cook
2024-06-06 18:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171768935175.54606.14878127902164737048.b4-ty@kernel.org \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=jean-philippe@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.