From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] log: respect rte_openlog_stream calls before rte_eal_init Date: Fri, 30 Sep 2016 17:01:33 +0200 Message-ID: <17179105.NJRITsrcxm@xps13> References: <20160928204244.8288-1-ouster@cs.stanford.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, david.marchand@6wind.com To: John Ousterhout Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 3A6D72931 for ; Fri, 30 Sep 2016 17:01:35 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id b4so52314307wmb.0 for ; Fri, 30 Sep 2016 08:01:35 -0700 (PDT) In-Reply-To: <20160928204244.8288-1-ouster@cs.stanford.edu> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-09-28 13:42, John Ousterhout: > Before this patch, rte_eal_init invoked rte_openlog_stream, cancelling > any application-specific logger and making it it impossible for an > application to capture the initial log messages generated during > rte_eal_init. With this patch, applications can capture all of the > log messages. It deserves an explanation of what the patch does, i.e. the new logic. If think you just want to remove the log init from rte_eal_init and use the default stream when it is not initialized (NULL). You could also remove the early log stream since the default one could work from the early stage. Indeed the complex log history was removed: http://dpdk.org/commit/a3f34a98 Thanks for improving the usability.