All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: wangyunjian <wangyunjian@huawei.com>, Nipun Gupta <nipun.gupta@nxp.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	stable@dpdk.org,
	"jerry.lilijun@huawei.com" <jerry.lilijun@huawei.com>,
	"xudingke@huawei.com" <xudingke@huawei.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
Date: Sun, 11 Oct 2020 22:06:06 +0200	[thread overview]
Message-ID: <1718706.bEVi5a3gDK@thomas> (raw)
In-Reply-To: <AM5PR0401MB2593340A9990E6B10B93FC79E60A0@AM5PR0401MB2593.eurprd04.prod.outlook.com>

> > This issue detected by coverity, CID#279443(Structurally dead code).
> > 
> > Coverity issue: 279443
> > Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> > ---
> > --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> > +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> > @@ -452,9 +452,10 @@ rte_qdma_reset(void)
> >  	/* In case there are pending jobs on any VQ, return -EBUSY */
> >  	for (i = 0; i < qdma_dev.max_vqs; i++) {
> >  		if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
> > -		    qdma_vqs[i].num_dequeues))
> > +		    qdma_vqs[i].num_dequeues)) {
> >  			DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d",
> > i);
> >  			return -EBUSY;
> > +		}
> >  	}

Acked by: Nipun Gupta <nipun.gupta@nxp.com>

I don't understand how it could work before in simplest case.
Changed title to "fix reset".

Applied, thanks



      reply	other threads:[~2020-10-11 20:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 13:41 [dpdk-dev] [PATCH] raw/dpaa2_qdma: fix missing parentheses wangyunjian
2020-09-09  1:11 ` [dpdk-dev] [PATCH v2] " wangyunjian
2020-10-06 21:33   ` Thomas Monjalon
2020-10-07  5:35   ` Nipun Gupta
2020-10-11 20:06     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1718706.bEVi5a3gDK@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jerry.lilijun@huawei.com \
    --cc=nipun.gupta@nxp.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.