All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	kraxel@redhat.com, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] docs/about/removed-features: Move the -soundhw into the right section
Date: Tue, 02 Aug 2022 13:34:38 +0200	[thread overview]
Message-ID: <1719315.SO3xn117Sn@silver> (raw)
In-Reply-To: <20220802075611.346835-1-thuth@redhat.com>

On Dienstag, 2. August 2022 09:56:11 CEST Thomas Huth wrote:
> The note about the removal of '-soundhw' has been accidentally added
> to the section of removed "linux-user mode CPUs" ... it should reside
> in the section about removed "System emulator command line arguments"
> instead.
> 
> Fixes: 039a68373c ("introduce -audio as a replacement for -soundhw")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---

Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

That can easily happen unfortunately, as the hierarchy syntax here, like in 
MAINTAINERS BTW, is not exactly perfect for the human eye.

>  docs/about/removed-features.rst | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/docs/about/removed-features.rst
> b/docs/about/removed-features.rst index c7b9dadd5d..925e22016f 100644
> --- a/docs/about/removed-features.rst
> +++ b/docs/about/removed-features.rst
> @@ -396,6 +396,13 @@ Use ``-display sdl`` instead.
> 
>  Use ``-display curses`` instead.
> 
> +Creating sound card devices using ``-soundhw`` (removed in 7.1)
> +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> +
> +Sound card devices should be created using ``-device`` or ``-audio``.
> +The exception is ``pcspk`` which can be activated using ``-machine
> +pcspk-audiodev=<name>``.
> +
> 
>  QEMU Machine Protocol (QMP) commands
>  ------------------------------------
> @@ -681,13 +688,6 @@ tripped up the CI testing and was suspected to be quite
> broken. For that reason the maintainers strongly suspected no one actually
> used it.
> 
> 
> -Creating sound card devices using ``-soundhw`` (removed in 7.1)
> -'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> -
> -Sound card devices should be created using ``-device`` or ``-audio``.
> -The exception is ``pcspk`` which can be activated using ``-machine
> -pcspk-audiodev=<name>``.
> -
>  TCG introspection features
>  --------------------------




  parent reply	other threads:[~2022-08-02 11:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02  7:56 [PATCH] docs/about/removed-features: Move the -soundhw into the right section Thomas Huth
2022-08-02  9:53 ` Daniel P. Berrangé
2022-08-02 11:34 ` Christian Schoenebeck [this message]
2022-08-04 11:47 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1719315.SO3xn117Sn@silver \
    --to=qemu_oss@crudebyte.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.