From: "Rob Herring (Arm)" <robh@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: krzk+dt@kernel.org, ericwouds@gmail.com, bert@biot.com,
conor+dt@kernel.org, tsbogend@alpha.franken.de,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
sander@svanheule.net, tglx@linutronix.de, paulburton@kernel.org,
john@phrozen.org, kabel@kernel.org, daniel.lezcano@linaro.org,
peterz@infradead.org, mail@birger-koblitz.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/9] dt-bindings: interrupt-controller: realtek,rtl-intc: Add rtl9300-intc
Date: Wed, 26 Jun 2024 23:37:58 -0600 [thread overview]
Message-ID: <171946667846.1784649.14059031623063461479.robh@kernel.org> (raw)
In-Reply-To: <20240627043317.3751996-7-chris.packham@alliedtelesis.co.nz>
On Thu, 27 Jun 2024 16:33:14 +1200, Chris Packham wrote:
> Add a compatible string for the interrupt controller found on the
> rtl930x SoCs. The interrupt controller has registers for VPE1 so these
> are added as a second reg cell.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v3:
> - Use items to describe the regs property
> Changes in v2:
> - Set reg:maxItems to 2 to allow for VPE1 registers on the rtl9300. Add
> a condition to enforce the old limit on other SoCs.
> - Connor and Krzysztof offered acks on v1 but I think the changes here
> are big enough to void those.
>
> .../interrupt-controller/realtek,rtl-intc.yaml | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/realtek,rtl-intc.example.dtb: interrupt-controller@3000: reg: [[12288, 24]] is too short
from schema $id: http://devicetree.org/schemas/interrupt-controller/realtek,rtl-intc.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240627043317.3751996-7-chris.packham@alliedtelesis.co.nz
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-06-27 5:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 4:33 [PATCH v3 0/9] mips: Support for RTL9302C Chris Packham
2024-06-27 4:33 ` [PATCH v3 1/9] mips: dts: realtek: use "serial" instead of "uart" in node name Chris Packham
2024-06-27 10:59 ` Marek Behún
2024-06-27 4:33 ` [PATCH v3 2/9] mips: dts: realtek: add device_type property to cpu node Chris Packham
2024-06-27 11:01 ` Marek Behún
2024-06-27 4:33 ` [PATCH v3 3/9] dt-bindings: vendor-prefixes: Add Cameo Communications Chris Packham
2024-06-27 7:39 ` Krzysztof Kozlowski
2024-06-27 4:33 ` [PATCH v3 4/9] dt-bindings: mips: realtek: Add rtl930x-soc compatible Chris Packham
2024-06-27 7:39 ` Krzysztof Kozlowski
2024-06-27 4:33 ` [PATCH v3 5/9] dt-bindings: timer: Add schema for realtek,otto-timer Chris Packham
2024-06-27 7:40 ` Krzysztof Kozlowski
2024-06-29 20:40 ` Sander Vanheule
2024-07-01 2:15 ` Chris Packham
2024-06-27 4:33 ` [PATCH v3 6/9] dt-bindings: interrupt-controller: realtek,rtl-intc: Add rtl9300-intc Chris Packham
2024-06-27 5:37 ` Rob Herring (Arm) [this message]
2024-06-27 7:41 ` Krzysztof Kozlowski
2024-06-30 22:12 ` Chris Packham
2024-07-01 3:02 ` Chris Packham
2024-06-27 4:33 ` [PATCH v3 7/9] clocksource: realtek: Add timer driver for rtl-otto platforms Chris Packham
2024-06-27 11:17 ` Marek Behún
2024-07-01 4:41 ` Chris Packham
2024-06-29 21:03 ` Sander Vanheule
2024-07-01 2:07 ` Chris Packham
2024-06-30 1:10 ` kernel test robot
2024-06-27 4:33 ` [PATCH v3 8/9] mips: generic: add fdt fixup for Realtek reference board Chris Packham
2024-06-27 11:19 ` Marek Behún
2024-06-27 17:48 ` Rob Herring
2024-06-30 22:39 ` Chris Packham
2024-06-27 4:33 ` [PATCH v3 9/9] mips: dts: realtek: Add RTL9302C board Chris Packham
2024-06-27 14:42 ` [PATCH v3 0/9] mips: Support for RTL9302C Rob Herring
2024-06-30 23:43 ` Chris Packham
2024-07-01 3:26 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171946667846.1784649.14059031623063461479.robh@kernel.org \
--to=robh@kernel.org \
--cc=bert@biot.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ericwouds@gmail.com \
--cc=john@phrozen.org \
--cc=kabel@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mail@birger-koblitz.de \
--cc=paulburton@kernel.org \
--cc=peterz@infradead.org \
--cc=sander@svanheule.net \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.