From: boris.ostrovsky@oracle.com
To: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] x86/xen: disable Firmware First mode for correctable memory errors
Date: Fri, 25 Sep 2020 09:45:26 -0400 [thread overview]
Message-ID: <171970df-5f6e-5a2b-e784-e62d300a005b@oracle.com> (raw)
In-Reply-To: <20200925101148.21012-1-jgross@suse.com>
On 9/25/20 6:11 AM, Juergen Gross wrote:
> @@ -1296,6 +1296,14 @@ asmlinkage __visible void __init xen_start_kernel(void)
>
> xen_smp_init();
>
> +#ifdef CONFIG_ACPI
> + /*
> + * Disable selecting "Firmware First mode" for correctable memory
> + * errors, as this is the duty of the hypervisor to decide.
> + */
> + acpi_disable_cmcff = 1;
> +#endif
Not that it matters greatly but should this go under if (xen_initial_domain()) clause a bit further down?
Either way:
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
next prev parent reply other threads:[~2020-09-25 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 10:11 [PATCH] x86/xen: disable Firmware First mode for correctable memory errors Juergen Gross
2020-09-25 13:45 ` boris.ostrovsky [this message]
2020-09-25 14:00 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171970df-5f6e-5a2b-e784-e62d300a005b@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.