From: "Rob Herring (Arm)" <robh@kernel.org>
To: Utsav Agarwal <utsav.agarwal@analog.com>
Cc: "Krzysztof Kozlowski" <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org,
"Michael Hennerich" <michael.hennerich@analog.com>,
devicetree@vger.kernel.org,
"Arturs Artamonovs" <arturs.artamonovs@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Vasileios Bimpikas" <vasileios.bimpikas@analog.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Oliver Gaskell" <oliver.gaskell@analog.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: input: Update dtbinding for adp5588
Date: Mon, 01 Jul 2024 10:27:55 -0600 [thread overview]
Message-ID: <171985127498.58137.18371204131413728327.robh@kernel.org> (raw)
In-Reply-To: <20240701-adp5588_gpio_support-v4-2-44bba0445e90@analog.com>
On Mon, 01 Jul 2024 16:04:51 +0100, Utsav Agarwal wrote:
> Updating dt bindings for adp5588. Following properties are now made
> optional:
> - interrupts
> - keypad,num-rows
> - keypad,num-columns
> - linux,keymap
> The proposed new property "gpio-only" has been added as an optional
> property with an additional example.
>
> Signed-off-by: Utsav Agarwal <utsav.agarwal@analog.com>
> ---
> .../devicetree/bindings/input/adi,adp5588.yaml | 28 ++++++++++++++++++----
> 1 file changed, 24 insertions(+), 4 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/adi,adp5588.yaml: gpio-only: missing type definition
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240701-adp5588_gpio_support-v4-2-44bba0445e90@analog.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-07-01 16:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 15:04 [PATCH v4 0/2] adp5588-keys: Support for dedicated gpio operation Utsav Agarwal
2024-07-01 15:04 ` Utsav Agarwal via B4 Relay
2024-07-01 15:04 ` [PATCH v4 1/2] Input: adp5588-keys - add support for pure gpio Utsav Agarwal
2024-07-01 15:04 ` Utsav Agarwal via B4 Relay
2024-07-01 15:04 ` [PATCH v4 2/2] dt-bindings: input: Update dtbinding for adp5588 Utsav Agarwal
2024-07-01 15:04 ` Utsav Agarwal via B4 Relay
2024-07-01 15:46 ` Conor Dooley
2024-07-01 17:46 ` Dmitry Torokhov
2024-07-02 10:20 ` Agarwal, Utsav
2024-07-02 15:42 ` Conor Dooley
2024-07-03 8:44 ` Nuno Sá
2024-07-01 16:27 ` Rob Herring (Arm) [this message]
2024-07-02 9:57 ` Agarwal, Utsav
2024-07-01 20:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171985127498.58137.18371204131413728327.robh@kernel.org \
--to=robh@kernel.org \
--cc=arturs.artamonovs@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=oliver.gaskell@analog.com \
--cc=utsav.agarwal@analog.com \
--cc=vasileios.bimpikas@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.