From: Thomas Monjalon <thomas@monjalon.net>
To: Megha Ajmera <megha.ajmera@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org, jasvinder.singh@intel.com,
cristian.dumitrescu@intel.com, david.marchand@redhat.com
Subject: Re: [PATCH v2] sched: fix for incorrect alignment of bitmap, pipe and queue structs in subport
Date: Sun, 19 Feb 2023 23:43:02 +0100 [thread overview]
Message-ID: <1720004.jNaZZp9DzI@thomas> (raw)
In-Reply-To: <11894451.zAa99ISigo@thomas>
19/02/2023 23:40, Thomas Monjalon:
> 07/02/2023 07:10, Megha Ajmera:
> > Big structures like bitmap, pipes and queues in subport are addressed
> > using offset of 'memory' field in subport structures. This means no other
> > variable should be added after 'memory' variable or else addressing of such
> > structs like bitmap etc. become incorrect.
> >
> > Realigned tc_ov_enabled variable in subport structure.
> >
> > Fixes: f5e60154ade ("sched: enable traffic class oversubscription conditionally")
> >
> > Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>
> I bet the impact is wrongly explained, but I don't want to look deeper.
> Applied.
And I've added Cc: stable@dpdk.org that David and Cristian asked for.
prev parent reply other threads:[~2023-02-19 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 14:54 [PATCH] sched: fix for tc_ov_enable flag position in subport structure Megha Ajmera
2023-01-10 11:12 ` Dumitrescu, Cristian
2023-01-10 11:27 ` David Marchand
2023-02-06 7:43 ` Thomas Monjalon
2023-02-06 9:32 ` Dumitrescu, Cristian
2023-02-07 9:09 ` Ajmera, Megha
2023-02-07 6:10 ` [PATCH v2] sched: fix for incorrect alignment of bitmap, pipe and queue structs in subport Megha Ajmera
2023-02-19 22:40 ` Thomas Monjalon
2023-02-19 22:43 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1720004.jNaZZp9DzI@thomas \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=megha.ajmera@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.