From: "Rob Herring (Arm)" <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, "Will Deacon" <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, "Krzysztof Kozlowski" <krzk+dt@kernel.org>
Subject: Re: [PATCH v2 1/1] dt-bindings: PCI: host-generic-pci: Drop minItems and maxItems of ranges
Date: Mon, 8 Jul 2024 11:10:52 -0600 [thread overview]
Message-ID: <172045865135.3461600.11204852988221577437.robh@kernel.org> (raw)
In-Reply-To: <20240704164019.611454-1-Frank.Li@nxp.com>
On Thu, 04 Jul 2024 12:40:19 -0400, Frank Li wrote:
> The ranges description states that "at least one non-prefetchable memory
> and one or both of prefetchable memory and IO space may also be provided."
>
> However, it should not limit the maximum number of ranges to 3.
>
> Freescale LS1028 and iMX95 use more than 3 ranges because the space splits
> some discontinuous prefetchable and non-prefetchable segments.
>
> Drop minItems and maxItems. The number of entries will be limited to 32
> in pci-bus-common.yaml in dtschema, which should be sufficient.
>
> Fix the below CHECK_DTBS warning.
> arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dtb: pcie@1f0000000: ranges: [[2181038080, 1, 4160749568, 1, 4160749568, 0, 1441792], [3254779904, 1, 4162191360, 1, 4162191360, 0, 458752], [2181038080, 1, 4162650112, 1, 4162650112, 0, 131072], [3254779904, 1, 4162781184, 1, 4162781184, 0, 131072], [2181038080, 1, 4162912256, 1, 4162912256, 0, 131072], [3254779904, 1, 4163043328, 1, 4163043328, 0, 131072], [2181038080, 1, 4227858432, 1, 4227858432, 0, 4194304]] is too long
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v1 to v2
> - Rework commit message
> - drop minItems and maxItems according to Rob's comments.
> ---
> Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2024-07-08 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 16:40 [PATCH v2 1/1] dt-bindings: PCI: host-generic-pci: Drop minItems and maxItems of ranges Frank Li
2024-07-08 17:10 ` Rob Herring (Arm) [this message]
2024-08-08 23:24 ` Frank Li
2024-08-09 19:06 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172045865135.3461600.11204852988221577437.robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.