All of lore.kernel.org
 help / color / mirror / Atom feed
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2.1 1/4] ARM: dts: davinci: da850: VPIF: add node and muxing
Date: Thu, 08 Dec 2016 15:51:50 +0200	[thread overview]
Message-ID: <1720737.m5D29H51CH@avalon> (raw)
In-Reply-To: <20161208001418.4469-1-khilman@baylibre.com>

Hi Kevin,

Thank you for the patch.

On Wednesday 07 Dec 2016 16:14:18 Kevin Hilman wrote:
> Add VPIF node an pins to da850 and enable on boards.  VPIF has two input
> channels described using the standard DT ports and enpoints.
> 
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> v2 -> v2.1: moved ports from SoC .dtsi to board .dts files.
> 
>  arch/arm/boot/dts/da850-evm.dts  | 20 ++++++++++++++++++++
>  arch/arm/boot/dts/da850-lcdk.dts | 13 +++++++++++++
>  arch/arm/boot/dts/da850.dtsi     | 27 ++++++++++++++++++++++++++-
>  3 files changed, 59 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/da850-evm.dts
> b/arch/arm/boot/dts/da850-evm.dts index 41de15fe15a2..cea36ee6fd07 100644
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -289,3 +289,23 @@
>  		};
>  	};
>  };
> +
> +&vpif {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&vpif_capture_pins>;
> +	status = "okay";
> +
> +	/* VPIF capture port */
> +	port {
> +		vpif_ch0: endpoint at 0 {
> +			  reg = <0>;
> +			  bus-width = <8>;
> +		};
> +
> +		vpif_ch1: endpoint at 1 {
> +			  reg = <1>;
> +			  bus-width = <8>;
> +			  data-shift = <8>;
> +		};
> +	};
> +};
> diff --git a/arch/arm/boot/dts/da850-lcdk.dts
> b/arch/arm/boot/dts/da850-lcdk.dts index 7b8ab21fed6c..5fc21528e0ba 100644
> --- a/arch/arm/boot/dts/da850-lcdk.dts
> +++ b/arch/arm/boot/dts/da850-lcdk.dts
> @@ -219,3 +219,16 @@
>  		};
>  	};
>  };
> +
> +&vpif {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&vpif_capture_pins>;
> +	status = "okay";
> +
> +	/* VPIF capture port */
> +	port {
> +		vpif_ch0: endpoint {
> +			  bus-width = <8>;
> +		};
> +	};
> +};
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index f79e1b91c680..5f0b40510b2b 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -186,7 +186,18 @@
>  					0xc 0x88888888 0xffffffff
> 
>  				>;
> 
>  			};
> -
> +			vpif_capture_pins: vpif_capture_pins {
> +				pinctrl-single,bits = <
> +					/* VP_DIN[2..7], VP_CLKIN1, VP_CLKIN0 
*/
> +					0x38 0x11111111 0xffffffff
> +					/* VP_DIN[10..15,0..1] */
> +					0x3c 0x11111111 0xffffffff
> +					/* VP_DIN[8..9] */
> +					0x40 0x00000011 0x000000ff
> +					/* VP_CLKIN3, VP_CLKIN2 */
> +					0x4c 0x00010100 0x000f0f00
> +				>;
> +			};
>  		};
>  		edma0: edma at 0 {
>  			compatible = "ti,edma3-tpcc";
> @@ -399,7 +410,21 @@
>  				<&edma0 0 1>;
>  			dma-names = "tx", "rx";
>  		};
> +
> +		vpif: video at 217000 {
> +			compatible = "ti,da850-vpif";
> +			reg = <0x217000 0x1000>;
> +			interrupts = <92>;
> +			status = "disabled";
> +
> +			/* VPIF capture port */
> +			port {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +			};
> +		};
>  	};
> +
>  	aemif: aemif at 68000000 {
>  		compatible = "ti,da850-aemif";
>  		#address-cells = <2>;

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2016-12-08 13:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07 19:31 [PATCH v2 0/4] ARM: davinci: da850: add/enable video capture Kevin Hilman
2016-12-07 19:31 ` [PATCH v2 1/4] ARM: dts: davinci: da850: VPIF: add node and muxing Kevin Hilman
2016-12-07 19:34   ` Laurent Pinchart
2016-12-07 23:15     ` Kevin Hilman
2016-12-08  0:14   ` [PATCH v2.1 " Kevin Hilman
2016-12-08 13:51     ` Laurent Pinchart [this message]
2017-01-03  5:35     ` Sekhar Nori
2017-01-09 19:32       ` Kevin Hilman
2016-12-07 19:31 ` [PATCH v2 2/4] ARM: davinci_all_defconfig: enable video capture as modules Kevin Hilman
2017-01-03  5:51   ` Sekhar Nori
2016-12-07 19:31 ` [PATCH v2 3/4] ARM: davinci: da8xx: add pdata-quirks, use for VPIF capture Kevin Hilman
2017-01-03  8:56   ` Sekhar Nori
2016-12-07 19:31 ` [PATCH v2 4/4] ARM: davinci: board-da850-evm: add I2C ID for VPIF Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1720737.m5D29H51CH@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.