All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Petr Machata <petrm@nvidia.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org, dsahern@kernel.org,
	mlxsw@nvidia.com, idosch@nvidia.com
Subject: Re: [PATCH net] net: nexthop: Initialize all fields in dumped nexthops
Date: Wed, 24 Jul 2024 14:20:31 +0000	[thread overview]
Message-ID: <172183083185.11114.3597522848172663609.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <8b06dd4ec057d912ca3947bacf15529272dea796.1721749627.git.petrm@nvidia.com>

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Tue, 23 Jul 2024 18:04:16 +0200 you wrote:
> struct nexthop_grp contains two reserved fields that are not initialized by
> nla_put_nh_group(), and carry garbage. This can be observed e.g. with
> strace (edited for clarity):
> 
>     # ip nexthop add id 1 dev lo
>     # ip nexthop add id 101 group 1
>     # strace -e recvmsg ip nexthop get id 101
>     ...
>     recvmsg(... [{nla_len=12, nla_type=NHA_GROUP},
>                  [{id=1, weight=0, resvd1=0x69, resvd2=0x67}]] ...) = 52
> 
> [...]

Here is the summary with links:
  - [net] net: nexthop: Initialize all fields in dumped nexthops
    https://git.kernel.org/netdev/net/c/6d745cd0e972

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2024-07-24 14:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-23 16:04 [PATCH net] net: nexthop: Initialize all fields in dumped nexthops Petr Machata
2024-07-23 16:50 ` Eric Dumazet
2024-07-23 17:26   ` Eric Dumazet
2024-07-23 17:41     ` Eric Dumazet
2024-07-23 17:42       ` Eric Dumazet
2024-07-24  9:12         ` Petr Machata
2024-07-24 10:36           ` Eric Dumazet
2024-07-25 12:42             ` Petr Machata
2024-07-25 12:56               ` Petr Machata
2024-07-24 14:20 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172183083185.11114.3597522848172663609.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.