All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Reilly <marc@cpdesign.com.au>
To: barebox@lists.infradead.org
Subject: Re: [PATCH] of_fix_tree: fo not fail when fixup fails
Date: Thu, 24 Sep 2015 08:35:54 +1000	[thread overview]
Message-ID: <1724333.SSeDMqRqa0@dev2> (raw)
In-Reply-To: <1443021836-10430-1-git-send-email-s.hauer@pengutronix.de>

Hi,

Should the subject be "do not fail .."  (s/fo/do) ?

Cheers,
Marc


On Wednesday, September 23, 2015 05:23:56 PM Sascha Hauer wrote:
> When a device tree fixup fails it is worth printing a warning, but
> we should not fail booting.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  common/oftree.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/common/oftree.c b/common/oftree.c
> index cafe46c..d408f14 100644
> --- a/common/oftree.c
> +++ b/common/oftree.c
> @@ -189,11 +189,9 @@ int of_fix_tree(struct device_node *node)
> 
>  	list_for_each_entry(of_fixup, &of_fixup_list, list) {
>  		ret = of_fixup->fixup(node, of_fixup->context);
> -		if (ret) {
> -			pr_err("Failed to fixup node in %pS: %s\n",
> +		if (ret)
> +			pr_warn("Failed to fixup node in %pS: %s\n",
>  					of_fixup->fixup, strerror(-ret));
> -			return ret;
> -		}
>  	}
> 
>  	return 0;


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-09-23 22:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23 15:23 [PATCH] of_fix_tree: fo not fail when fixup fails Sascha Hauer
2015-09-23 22:35 ` Marc Reilly [this message]
2015-09-24  6:01   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1724333.SSeDMqRqa0@dev2 \
    --to=marc@cpdesign.com.au \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.