Re: [PATCH] ide.c: microscopic size and readability optimization

[Paul Sokolovsky <pmiscml@gmail.com>]

Hello Borislav,

Thursday, May 17, 2007, 2:25:54 PM, you wrote:

> -----
> From: bbpetkov@yahoo.de

> A very small size (object file 432 bytes smaller) and readability optimization of ide.c

        And how these "optimizations" fit with BUG_ON() purpose - to
be able to easily identify cause and place of the failure? You
could just remove them altogether and claim that you did even "better"
"optimization".

> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>

> --
> Index: 22-rc1/drivers/ide/ide.c
> ===================================================================
> --- 22-rc1/drivers/ide/ide.c.orig
> +++ 22-rc1/drivers/ide/ide.c
> @@ -568,10 +568,8 @@ void ide_unregister(unsigned int index)
>         ide_hwgroup_t *hwgroup;
>         int irq_count = 0, unit;

> -       BUG_ON(index >= MAX_HWIFS);
> +       BUG_ON(index >= MAX_HWIFS || in_interrupt() || irqs_disabled());

> -       BUG_ON(in_interrupt());
> -       BUG_ON(irqs_disabled());
>         down(&ide_cfg_sem);



-- 
Best regards,
 Paul                            mailto:pmiscml@gmail.com