From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E628DCF9C6F for ; Tue, 24 Sep 2024 11:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Date:Message-Id:From:Subject:Content-Transfer-Encoding:MIME-Version: Content-Type:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MZ1hLRa1fhMXSNothHe495edLmqu3u0Mo018Lv24FFQ=; b=QqHeLnqDPrAUGaC46mOpgKbcUR 8FoBNXcJ0sXnToL0pEs6bqaK8t010Aw9ua9ipCpxX6Y2NT8R0s76O1hQTgIed0I6e9Fy6oZNMhip8 TdDB4FW6oCQ0VZjAC1vr80CpP/1MVO/pSi4tXesc83aT4g0toC1IVTLTquIAa8W32grjhiQV9PH+a ZS2QH+MJ1ln4fyP1Zl8K1mlaIE5qmczuNWzVlxZyqB7cqgMCG+oBvlC/Hwc0v3Pa8U5oBEC4TYVUR FPYsKfVP66/nc/ZZhZiW/m3I9QFI7kHG8IL8d7026Mr/AuMee6rjjeFzDIJ2NF1gmWRbFiZgkxaUF sK9PtYCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1st3HT-000000024Sn-0yWC; Tue, 24 Sep 2024 11:00:31 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1st2Bg-00000001soR-39Wv for linux-arm-kernel@lists.infradead.org; Tue, 24 Sep 2024 09:50:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C99D25C5A77; Tue, 24 Sep 2024 09:50:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E62CC4CEC4; Tue, 24 Sep 2024 09:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727171425; bh=BurBzI8ngKah39LvdFErebusrYUIIpd4vTRNgU0ne18=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=ckcSzzabzQRvieGmBOhpLCQHIKlOLNnNCe/Wv/ASZKQ43J9WkjJM1qe55/8img+Kz xHg/VsXpn+QkGkHTeN/9qUFrA+p54ADKDutClX5MWiR36zVNrlCP7hwHkVpZtosRbx cfCjymuiHTfIdaBMewt1uYyfnFObls5HqB2qUR3kzf7nBfPqI2hicNXSlZ3tpaGH3h r4Y/M9yBTSjCv2vpC6/OpgA9hcJ1VRdovnPBxoA/BwP/uTrzbacl0ziar3k/Apb1HS Fzspy0pZDgCrmRkqeAZKv+NXDAd9uFsSkFaqnTtjRC+TIYykVdLRD2fY6/nApOpjtl 24s0Z83qSprWg== Received: from [10.30.226.235] (localhost [IPv6:::1]) by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id EAFAB3806655; Tue, 24 Sep 2024 09:50:28 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v2 1/1] net: stmmac: Fix zero-division error when disabling tc cbs From: patchwork-bot+netdevbpf@kernel.org Message-Id: <172717142776.3968801.9111597655574522093.git-patchwork-notify@kernel.org> Date: Tue, 24 Sep 2024 09:50:27 +0000 References: <20240918061422.1589662-1-khai.wen.tan@linux.intel.com> In-Reply-To: <20240918061422.1589662-1-khai.wen.tan@linux.intel.com> To: KhaiWenTan Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, xiaolei.wang@windriver.com, horms@kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, yong.liang.choong@linux.intel.com, khai.wen.tan@intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_025028_878317_EA687123 X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Wed, 18 Sep 2024 14:14:22 +0800 you wrote: > The commit b8c43360f6e4 ("net: stmmac: No need to calculate speed divider > when offload is disabled") allows the "port_transmit_rate_kbps" to be > set to a value of 0, which is then passed to the "div_s64" function when > tc-cbs is disabled. This leads to a zero-division error. > > When tc-cbs is disabled, the idleslope, sendslope, and credit values the > credit values are not required to be configured. Therefore, adding a return > statement after setting the txQ mode to DCB when tc-cbs is disabled would > prevent a zero-division error. > > [...] Here is the summary with links: - [net,v2,1/1] net: stmmac: Fix zero-division error when disabling tc cbs https://git.kernel.org/netdev/net/c/675faf5a14c1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html