From: patchwork-bot+netdevbpf@kernel.org
To: Eduard Zingerman <eddyz87@gmail.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, martin.lau@linux.dev, kernel-team@fb.com,
yonghong.song@linux.dev, kongln9170@gmail.com
Subject: Re: [PATCH bpf v1 1/2] bpf: sync_linked_regs() must preserve subreg_def
Date: Fri, 27 Sep 2024 23:00:32 +0000 [thread overview]
Message-ID: <172747803277.2107802.3943933559920979953.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240924210844.1758441-1-eddyz87@gmail.com>
Hello:
This series was applied to bpf/bpf.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Tue, 24 Sep 2024 14:08:43 -0700 you wrote:
> Range propagation must not affect subreg_def marks, otherwise the
> following example is rewritten by verifier incorrectly when
> BPF_F_TEST_RND_HI32 flag is set:
>
> 0: call bpf_ktime_get_ns call bpf_ktime_get_ns
> 1: r0 &= 0x7fffffff after verifier r0 &= 0x7fffffff
> 2: w1 = w0 rewrites w1 = w0
> 3: if w0 < 10 goto +0 --------------> r11 = 0x2f5674a6 (r)
> 4: r1 >>= 32 r11 <<= 32 (r)
> 5: r0 = r1 r1 |= r11 (r)
> 6: exit; if w0 < 0xa goto pc+0
> r1 >>= 32
> r0 = r1
> exit
>
> [...]
Here is the summary with links:
- [bpf,v1,1/2] bpf: sync_linked_regs() must preserve subreg_def
https://git.kernel.org/bpf/bpf/c/27cda47e7819
- [bpf,v1,2/2] selftests/bpf: verify that sync_linked_regs preserves subreg_def
https://git.kernel.org/bpf/bpf/c/99a648c951ba
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-09-27 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 21:08 [PATCH bpf v1 1/2] bpf: sync_linked_regs() must preserve subreg_def Eduard Zingerman
2024-09-24 21:08 ` [PATCH bpf v1 2/2] selftests/bpf: verify that sync_linked_regs preserves subreg_def Eduard Zingerman
2024-09-25 9:44 ` [PATCH bpf v1 1/2] bpf: sync_linked_regs() must preserve subreg_def Daniel Borkmann
2024-09-25 19:48 ` Eduard Zingerman
2024-09-25 20:17 ` Daniel Borkmann
2024-09-27 23:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172747803277.2107802.3943933559920979953.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=kernel-team@fb.com \
--cc=kongln9170@gmail.com \
--cc=martin.lau@linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.