From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Walter Subject: Re: kernels > v4.12 oops/crash with ipsec-traffic: bisected to b838d5e1c5b6e57b10ec8af2268824041e3ea911: ipv4: mark DST_NOGC and remove the operation of dst_free() Date: Mon, 10 Sep 2018 12:46:04 +0200 Message-ID: <1727961.pNJLMAiven@stwm.de> References: <3482600.6PjfSIYROA@stwm.de> <20180910063739.GX23674@gauss3.secunet.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Cc: Steffen Klassert , Network Development , weiwan@google.com, Tobias Hommel , edumazet@google.com To: Kristian Evensen Return-path: Received: from mailin.studentenwerk.mhn.de ([141.84.225.229]:51814 "EHLO email.studentenwerk.mhn.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727639AbeIJPjc (ORCPT ); Mon, 10 Sep 2018 11:39:32 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Am Montag, 10. September 2018, 10:18:47 schrieb Kristian Evensen: > Hi, > > Thanks everyone for all the effort in debugging this issue. > > On Mon, Sep 10, 2018 at 8:39 AM Steffen Klassert > > wrote: > > The easy fix that could be backported to stable would be > > to check skb->dst for NULL and drop the packet in that case. > > Thought I should just chime in and say that we deployed this > work-around when we started observing the error back in June. Since > then we have not seen any crashes. Also, we have instrumented some of > our kernels to count the number of times the error is hit (overall + > consecutive). Compared to the overall number of packets, the error > happens very rarely. With our workloads, we on average see the error > once every couple of days. > Would you mind send us yout patch (with the accounting) so that we can check how often that happens here? Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts