From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 0/4 v2] Audio support for adv7511 hdmi bridge Date: Tue, 18 Oct 2016 17:42:25 +0300 Message-ID: <1728900.jTuP8Bd5Ss@avalon> References: <1472514096-10915-1-git-send-email-john.stultz@linaro.org> <3891360.bEMoZb6Wzz@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 632306E743 for ; Tue, 18 Oct 2016 14:42:30 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: kuninori.morimoto.gx@renesas.com, Guodong Xu , "dri-devel@lists.freedesktop.org" , lkml , Jose Abreu , Wolfram Sang , Mark Brown , Srinivas Kandagatla , Dave Long , Andy Green , Zhangfei Gao List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKCihDQydpbmcgTW9yaW1vdG8tc2FuKQoKT24gVHVlc2RheSAwNiBTZXAgMjAxNiAx NToxNzo1OCBKb2huIFN0dWx0eiB3cm90ZToKPiBPbiBUdWUsIEF1ZyAzMCwgMjAxNiBhdCAyOjIz IEFNLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4gSGkgSm9obiwKPiA+IAo+ID4gVGhhbmsg eW91IGZvciB0aGUgcGF0Y2hlcy4KPiAKPiBUaGFua3Mgc28gbXVjaCBmb3IgdGhlIHJldmlldyEg SSdtIHJld29ya2luZyB0aGUgcGF0Y2hzZXQgbm93IGFuZCB3aWxsCj4gYmUgc2VuZGluZyBvdXQg YW4gdXBkYXRlZCBzZXQgc29vbiEKPiAKPiA+PiBUaGlzIHBhdGNoc2V0LCBhbG9uZyB3aXRoIHRo ZSBpMnMgZHJpdmVyIGFuZCBkdHMgY2hhbmdlcyBhbGxvd3MKPiA+PiBIRE1JIGF1ZGlvIHRvIHdv cmsgb24gdGhlIEhpS2V5IGJvYXJkLgo+ID4gCj4gPiBXaGVyZSBhcmUgdGhlIGR0cyBjaGFuZ2Vz ID8KPiAKPiBIZXJlJ3Mgd2hhdCBJJ20gdXNpbmcgdG8gZ2V0IGl0IHdvcmtpbmc6Cj4gaHR0cHM6 Ly9naXQubGluYXJvLm9yZy9wZW9wbGUvam9obi5zdHVsdHovYW5kcm9pZC1kZXYuZ2l0L2NvbW1p dGRpZmYvMTAyNGNiNAo+IDg1YjZmMDBhN2UzNTVjZTYwNDI1ZjA0YTU4NDQ4MTE0OAoKVGhhbmsg eW91LgoKV2UgbmVlZCB0byBzdGFuZGFyZGl6ZSBEVCBiaW5kaW5ncyBmb3IgSERNSSBzb3VuZCBv dXRwdXQuIE1vcmltb3RvLXNhbiwgY291bGQgCnlvdSBoYXZlIGEgbG9vayBhdCB0aGUgRFQgYmlu ZGluZ3MgcHJvcG9zYWwgZm9yIEhETUkgc291bmQgb3V0cHV0IHdpdGggdGhlIApBRFY3NTExLCBh bmQgY29tbWVudCBvbiB3aGV0aGVyIGl0IG1hdGNoZXMgdGhlIGFwcHJvYWNoIHlvdSd2ZSB0YWtl biBmb3IgSERNSSAKc291bmQgb3V0cHV0IG9uIFItQ2FyIEdlbjMgPwoKPiBCdXQgYWdhaW4sIHRo YXQncyBkZXBlbmRlbnQgb24gdGhlIGszZG1hIGRyaXZlciAocXVldWVkKSwgdGhlIGhpNjIxMAo+ IGkycyBkcml2ZXIgKHN0aWxsIGJlaW5nIHJld29ya2VkKSwgYW5kIGFkdjc1MTEgYXVkaW8gKHRo aXMgcGF0Y2hzZXQpLgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761731AbcJROmo (ORCPT ); Tue, 18 Oct 2016 10:42:44 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:59567 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761553AbcJROma (ORCPT ); Tue, 18 Oct 2016 10:42:30 -0400 From: Laurent Pinchart To: John Stultz Cc: lkml , David Airlie , Archit Taneja , Wolfram Sang , Srinivas Kandagatla , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Boris Brezillon , Andy Green , Dave Long , Guodong Xu , Zhangfei Gao , Mark Brown , Lars-Peter Clausen , Jose Abreu , "dri-devel@lists.freedesktop.org" , kuninori.morimoto.gx@renesas.com Subject: Re: [PATCH 0/4 v2] Audio support for adv7511 hdmi bridge Date: Tue, 18 Oct 2016 17:42:25 +0300 Message-ID: <1728900.jTuP8Bd5Ss@avalon> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: References: <1472514096-10915-1-git-send-email-john.stultz@linaro.org> <3891360.bEMoZb6Wzz@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, (CC'ing Morimoto-san) On Tuesday 06 Sep 2016 15:17:58 John Stultz wrote: > On Tue, Aug 30, 2016 at 2:23 AM, Laurent Pinchart wrote: > > Hi John, > > > > Thank you for the patches. > > Thanks so much for the review! I'm reworking the patchset now and will > be sending out an updated set soon! > > >> This patchset, along with the i2s driver and dts changes allows > >> HDMI audio to work on the HiKey board. > > > > Where are the dts changes ? > > Here's what I'm using to get it working: > https://git.linaro.org/people/john.stultz/android-dev.git/commitdiff/1024cb4 > 85b6f00a7e355ce60425f04a584481148 Thank you. We need to standardize DT bindings for HDMI sound output. Morimoto-san, could you have a look at the DT bindings proposal for HDMI sound output with the ADV7511, and comment on whether it matches the approach you've taken for HDMI sound output on R-Car Gen3 ? > But again, that's dependent on the k3dma driver (queued), the hi6210 > i2s driver (still being reworked), and adv7511 audio (this patchset). -- Regards, Laurent Pinchart