From: "Hajda, Andrzej" <andrzej.hajda@intel.com>
To: "Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
igt-dev@lists.freedesktop.org,
"Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Subject: Re: [PATCH] lib/gpu_cmds: use proper surface format for all platforms
Date: Tue, 20 Oct 2026 15:30:53 +0200 [thread overview]
Message-ID: <1730d442-4c14-4edd-95ae-2e852fe9fd88@intel.com> (raw)
In-Reply-To: <20261020105648.3uerun3eqj3mvguz@kamilkon-DESK.igk.intel.com>
W dniu 20.10.2026 o 12:56, Kamil Konieczny pisze:
> Hi Andrzej,
> On 2026-10-19 at 19:23:31 +0200, Andrzej Hajda wrote:
>> On older platforms (< 2.0) SURFACEFORMAT_R8_UNORM was used always,
>> regardless of bpp, as it does not matter for media block send messages.
>> Since 2.0 format reflecting bpp is required. The code was adjusted
>> only for newer platforms, conditionals were added suggesting this is
>> kind-of-workaround. The patch removes these conditionals, there is no
>> point to keep them and perform cargo cult on new code.
>>
>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
>> ---
> LGTM
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>
> Regards,
> Kamil
Thx, merged.
Regards
Andrzej
next prev parent reply other threads:[~2026-10-20 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 17:23 [PATCH] lib/gpu_cmds: use proper surface format for all platforms Andrzej Hajda
2026-10-19 22:51 ` ✗ Xe.CI.BAT: failure for " Patchwork
2026-10-19 23:09 ` ✓ i915.CI.BAT: success " Patchwork
2026-10-20 1:06 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-10-20 6:32 ` ✗ i915.CI.Full: " Patchwork
2026-10-20 10:35 ` ✓ Xe.CI.BAT: success " Patchwork
2026-10-20 10:56 ` [PATCH] " Kamil Konieczny
2026-10-20 13:30 ` Hajda, Andrzej [this message]
2026-10-20 14:07 ` ✗ Fi.CI.BAT: failure for lib/gpu_cmds: use proper surface format for all platforms (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1730d442-4c14-4edd-95ae-2e852fe9fd88@intel.com \
--to=andrzej.hajda@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.