From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] meson: error out on failed kernel module builds
Date: Tue, 19 May 2020 18:01:17 +0200 [thread overview]
Message-ID: <1731174.MHSsGVy7CF@thomas> (raw)
In-Reply-To: <20200511102739.GC1957@bricha3-MOBL.ger.corp.intel.com>
11/05/2020 12:27, Bruce Richardson:
> On Mon, May 11, 2020 at 11:25:13AM +0100, Anatoly Burakov wrote:
> > Now that kernel modules aren't built by default, we can be more
> > strict with their build process, and fail the build if they were
> > requested to be built, but weren't.
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> I think erroring out is the right thing to do, now that modules need to be
> explicitly enabled.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
prev parent reply other threads:[~2020-05-19 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 10:25 [dpdk-dev] [PATCH] meson: error out on failed kernel module builds Anatoly Burakov
2020-05-11 10:27 ` Bruce Richardson
2020-05-19 16:01 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1731174.MHSsGVy7CF@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.