From: patchwork-bot+netdevbpf@kernel.org
To: Eduard Zingerman <eddyz87@gmail.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, martin.lau@linux.dev, kernel-team@fb.com,
yonghong.song@linux.dev
Subject: Re: [bpf-next 0/4] selftests/bpf: fix for bpf_signal stalls, watchdog for test_progs
Date: Tue, 12 Nov 2024 22:10:35 +0000 [thread overview]
Message-ID: <173144943523.689304.3368076379065536424.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241112110906.3045278-1-eddyz87@gmail.com>
Hello:
This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Tue, 12 Nov 2024 03:09:02 -0800 you wrote:
> Test case 'bpf_signal' had been recently reported to stall, both on
> the mailing list [1] and CI [2]. The stall is caused by CPU cycles
> perf event not being delivered within expected time frame, before test
> process enters system call and waits indefinitely.
>
> This patch-set addresses the issue in several ways:
> - A watchdog timer is added to test_progs.c runner:
> - it prints current sub-test name to stderr if sub-test takes longer
> than 10 seconds to finish;
> - it terminates process executing sub-test if sub-test takes longer
> than 120 seconds to finish.
> - The test case is updated to await perf event notification with a
> timeout and a few retries, this serves two purposes:
> - busy loops longer to increase the time frame for CPU cycles event
> generation/delivery;
> - makes a timeout, not stall, a worst case scenario.
> - The test case is updated to lower frequency of perf events, as high
> frequency of such events caused events generation throttling,
> which in turn delayed events delivery by amount of time sufficient
> to cause test case failure.
>
> [...]
Here is the summary with links:
- [bpf-next,1/4] selftests/bpf: watchdog timer for test_progs
https://git.kernel.org/bpf/bpf-next/c/d9d4d127e813
- [bpf-next,2/4] selftests/bpf: add read_with_timeout() utility function
https://git.kernel.org/bpf/bpf-next/c/03066ed3105a
- [bpf-next,3/4] selftests/bpf: allow send_signal test to timeout
https://git.kernel.org/bpf/bpf-next/c/3209139d00e5
- [bpf-next,4/4] selftests/bpf: update send_signal to lower perf evemts frequency
https://git.kernel.org/bpf/bpf-next/c/4edab4c55d2d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-11-12 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 11:09 [bpf-next 0/4] selftests/bpf: fix for bpf_signal stalls, watchdog for test_progs Eduard Zingerman
2024-11-12 11:09 ` [bpf-next 1/4] selftests/bpf: watchdog timer " Eduard Zingerman
2024-11-12 11:09 ` [bpf-next 2/4] selftests/bpf: add read_with_timeout() utility function Eduard Zingerman
2024-11-12 11:09 ` [bpf-next 3/4] selftests/bpf: allow send_signal test to timeout Eduard Zingerman
2024-11-12 11:09 ` [bpf-next 4/4] selftests/bpf: update send_signal to lower perf evemts frequency Eduard Zingerman
2024-11-12 22:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173144943523.689304.3368076379065536424.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.